Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2034843003: Add Expect-Staple to preload list (Closed)

Created:
4 years, 6 months ago by dadrian
Modified:
4 years, 6 months ago
Reviewers:
lgarron, agl, estark
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address comments from estark@ #

Patch Set 3 : Update test domain names #

Total comments: 1

Patch Set 4 : Initialize all variables #

Patch Set 5 : Patch with static.h #

Total comments: 2

Patch Set 6 : Test enable_static_expect_staple_ is followed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -2 lines) Patch
M net/http/transport_security_state.h View 1 2 3 4 3 chunks +28 lines, -0 lines 0 comments Download
M net/http/transport_security_state.cc View 1 2 3 4 5 chunks +45 lines, -1 line 0 comments Download
M net/http/transport_security_state_static.json View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 2 3 4 5 4 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (7 generated)
dadrian
This corresponds with https://github.com/chromium/hstspreload/pull/78. I regenerated //net/http/transport_security_state_static.h with the Expect-Staple changes, although it looks like ...
4 years, 6 months ago (2016-06-02 20:22:37 UTC) #3
estark
https://codereview.chromium.org/2034843003/diff/1/net/http/transport_security_state.cc File net/http/transport_security_state.cc (right): https://codereview.chromium.org/2034843003/diff/1/net/http/transport_security_state.cc#newcode379 net/http/transport_security_state.cc:379: bool es_include_subdomains; nit: even though it's long my preference ...
4 years, 6 months ago (2016-06-02 22:41:51 UTC) #4
dadrian
https://codereview.chromium.org/2034843003/diff/1/net/http/transport_security_state.cc File net/http/transport_security_state.cc (right): https://codereview.chromium.org/2034843003/diff/1/net/http/transport_security_state.cc#newcode379 net/http/transport_security_state.cc:379: bool es_include_subdomains; On 2016/06/02 22:41:51, estark wrote: > nit: ...
4 years, 6 months ago (2016-06-02 23:17:25 UTC) #5
lgarron
As you observed, the transport_security_state_static.h file diff is too large to upload to Rietveld until ...
4 years, 6 months ago (2016-06-03 00:41:42 UTC) #6
dadrian
https://codereview.chromium.org/2034843003/diff/1/net/http/transport_security_state_static.json File net/http/transport_security_state_static.json (right): https://codereview.chromium.org/2034843003/diff/1/net/http/transport_security_state_static.json#newcode215 net/http/transport_security_state_static.json:215: + { "name": "expect-staple-test.badssl.com", "expect_staple": true, "expect_staple_report_uri": "https://report.badssl.com/expect-staple", "include_subdomains_for_expect_staple": ...
4 years, 6 months ago (2016-06-03 18:08:33 UTC) #7
estark
On 2016/06/03 18:08:33, dadrian wrote: > https://codereview.chromium.org/2034843003/diff/1/net/http/transport_security_state_static.json > File net/http/transport_security_state_static.json (right): > > https://codereview.chromium.org/2034843003/diff/1/net/http/transport_security_state_static.json#newcode215 > ...
4 years, 6 months ago (2016-06-03 18:10:18 UTC) #8
lgarron
On 2016/06/03 at 18:10:18, estark wrote: > On 2016/06/03 18:08:33, dadrian wrote: > > https://codereview.chromium.org/2034843003/diff/1/net/http/transport_security_state_static.json ...
4 years, 6 months ago (2016-06-03 21:48:59 UTC) #9
lgarron
On 2016/06/03 at 21:48:59, lgarron wrote: > On 2016/06/03 at 18:10:18, estark wrote: > > ...
4 years, 6 months ago (2016-06-03 21:49:25 UTC) #10
dadrian
On 2016/06/03 21:49:25, lgarron wrote: > On 2016/06/03 at 21:48:59, lgarron wrote: > > On ...
4 years, 6 months ago (2016-06-03 22:14:43 UTC) #11
lgarron
LGTM for the JSON. It would normally be agl@, but seeing as he is gone ...
4 years, 6 months ago (2016-06-03 22:21:42 UTC) #12
agl
LGTM Rubber stamp for net/
4 years, 6 months ago (2016-06-03 22:27:03 UTC) #14
lgarron
I pinged agl@; he's willing to rubber-stamp if Emily and I approve.
4 years, 6 months ago (2016-06-03 22:28:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034843003/20001
4 years, 6 months ago (2016-06-03 22:28:50 UTC) #17
estark
lgtm if you initialize enable_static_expect_staple_ and set it to false in the same place that ...
4 years, 6 months ago (2016-06-03 22:31:36 UTC) #19
estark
https://codereview.chromium.org/2034843003/diff/40001/net/http/transport_security_state.cc File net/http/transport_security_state.cc (right): https://codereview.chromium.org/2034843003/diff/40001/net/http/transport_security_state.cc#newcode620 net/http/transport_security_state.cc:620: enable_static_expect_staple_(false), I think you can initialize this to true ...
4 years, 6 months ago (2016-06-03 22:53:04 UTC) #20
estark
https://codereview.chromium.org/2034843003/diff/40001/net/http/transport_security_state_unittest.cc File net/http/transport_security_state_unittest.cc (right): https://codereview.chromium.org/2034843003/diff/40001/net/http/transport_security_state_unittest.cc#newcode1688 net/http/transport_security_state_unittest.cc:1688: TransportSecurityStateTest::EnableStaticExpectStaple(&state); Sorry, I am doing a terrible job getting ...
4 years, 6 months ago (2016-06-03 22:54:14 UTC) #21
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/d59a9318491742f487eaea3d10920c063065ec90 Cr-Commit-Position: refs/heads/master@{#397844}
4 years, 6 months ago (2016-06-03 23:43:23 UTC) #23
lgarron
4 years, 6 months ago (2016-06-03 23:44:27 UTC) #25
Message was sent while issue was closed.
Committed patchset #6 (id:60001) manually as
d59a9318491742f487eaea3d10920c063065ec90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698