Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2034703003: Remove use of deprecated MessageLoop methods in blimp. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of deprecated MessageLoop methods in blimp. MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon are deprecated. This CL makes the following replacements to remove some uses of these methods: "MessageLoop(ForUI|ForIO)::current()->PostTask" -> "ThreadTaskRunnerHandle::Get()->PostTask" "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" -> "ThreadTaskRunnerHandle::Get()->PostDelayedTask" "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" -> "ThreadTaskRunnerHandle::Get()->DeleteSoon" "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" -> "ThreadTaskRunnerHandle::Get()->ReleaseSoon" In files where these replacements are made, it adds these includes: #include "base/location.h" #include "base/single_thread_task_runner.h" #include "base/threading/thread_task_runner_handle.h" And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why ThreadTaskRunnerHandle::Get() instead of MessageLoop::current()->task_runner()? - The two are equivalent on threads that run a MessageLoop. - MessageLoop::current() doesn't work in base/task_scheduler because the scheduler's thread don't run MessageLoops. This CL will therefore facilitate the migration of browser threads to base/task_scheduler. Steps to generate this patch: 1. Run message_loop_cleanup.py (see this CL's comments). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=dtrainor@chromium.org Committed: https://crrev.com/f928849b53b6d710fcaa090962b8ac49ef978024 Cr-Commit-Position: refs/heads/master@{#398149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M blimp/net/blimp_message_output_buffer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M blimp/net/blob_channel/blob_channel_integration_test.cc View 2 chunks +4 lines, -1 line 0 comments Download
M blimp/net/browser_connection_handler_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M blimp/net/stream_packet_reader.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M blimp/net/stream_packet_writer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M blimp/net/tcp_engine_transport.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M blimp/net/thread_pipe_manager_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-06 16:40:29 UTC) #1
David Trainor- moved to gerrit
lgtm
4 years, 6 months ago (2016-06-06 21:16:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034703003/1
4 years, 6 months ago (2016-06-06 21:47:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 22:46:56 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 22:48:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f928849b53b6d710fcaa090962b8ac49ef978024
Cr-Commit-Position: refs/heads/master@{#398149}

Powered by Google App Engine
This is Rietveld 408576698