Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: blimp/net/thread_pipe_manager_unittest.cc

Issue 2034703003: Remove use of deprecated MessageLoop methods in blimp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/net/tcp_engine_transport.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/net/thread_pipe_manager.h" 5 #include "blimp/net/thread_pipe_manager.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
11 #include "base/single_thread_task_runner.h"
11 #include "base/threading/thread.h" 12 #include "base/threading/thread.h"
13 #include "base/threading/thread_task_runner_handle.h"
12 #include "blimp/common/create_blimp_message.h" 14 #include "blimp/common/create_blimp_message.h"
13 #include "blimp/net/blimp_message_thread_pipe.h" 15 #include "blimp/net/blimp_message_thread_pipe.h"
14 #include "blimp/net/browser_connection_handler.h" 16 #include "blimp/net/browser_connection_handler.h"
15 #include "blimp/net/test_common.h" 17 #include "blimp/net/test_common.h"
16 #include "net/base/net_errors.h" 18 #include "net/base/net_errors.h"
17 #include "net/base/test_completion_callback.h" 19 #include "net/base/test_completion_callback.h"
18 #include "testing/gmock/include/gmock/gmock.h" 20 #include "testing/gmock/include/gmock/gmock.h"
19 #include "testing/gtest/include/gtest/gtest.h" 21 #include "testing/gtest/include/gtest/gtest.h"
20 22
21 using testing::_; 23 using testing::_;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 DCHECK(task_runner_->RunsTasksOnCurrentThread()); 68 DCHECK(task_runner_->RunsTasksOnCurrentThread());
67 message_processor_->ProcessMessage(std::move(message), 69 message_processor_->ProcessMessage(std::move(message),
68 net::CompletionCallback()); 70 net::CompletionCallback());
69 } 71 }
70 72
71 // BlimpMessageProcessor implementation. 73 // BlimpMessageProcessor implementation.
72 void ProcessMessage(std::unique_ptr<BlimpMessage> message, 74 void ProcessMessage(std::unique_ptr<BlimpMessage> message,
73 const net::CompletionCallback& callback) override { 75 const net::CompletionCallback& callback) override {
74 DCHECK(task_runner_->RunsTasksOnCurrentThread()); 76 DCHECK(task_runner_->RunsTasksOnCurrentThread());
75 ASSERT_EQ(feature_case_, message->feature_case()); 77 ASSERT_EQ(feature_case_, message->feature_case());
76 base::MessageLoop::current()->PostTask( 78 base::ThreadTaskRunnerHandle::Get()->PostTask(
77 FROM_HERE, base::Bind(&FakeFeaturePeer::ForwardMessage, 79 FROM_HERE, base::Bind(&FakeFeaturePeer::ForwardMessage,
78 base::Unretained(this), base::Passed(&message))); 80 base::Unretained(this), base::Passed(&message)));
79 if (!callback.is_null()) 81 if (!callback.is_null())
80 callback.Run(net::OK); 82 callback.Run(net::OK);
81 } 83 }
82 84
83 BlimpMessage::FeatureCase feature_case_; 85 BlimpMessage::FeatureCase feature_case_;
84 BlimpMessageProcessor* message_processor_ = nullptr; 86 BlimpMessageProcessor* message_processor_ = nullptr;
85 scoped_refptr<base::SequencedTaskRunner> task_runner_; 87 scoped_refptr<base::SequencedTaskRunner> task_runner_;
86 }; 88 };
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 std::move(input_message), cb1.callback()); 170 std::move(input_message), cb1.callback());
169 net::TestCompletionCallback cb2; 171 net::TestCompletionCallback cb2;
170 tab_control_feature_->outgoing_message_processor()->ProcessMessage( 172 tab_control_feature_->outgoing_message_processor()->ProcessMessage(
171 std::move(tab_control_message), cb2.callback()); 173 std::move(tab_control_message), cb2.callback());
172 174
173 EXPECT_EQ(net::OK, cb1.WaitForResult()); 175 EXPECT_EQ(net::OK, cb1.WaitForResult());
174 EXPECT_EQ(net::OK, cb2.WaitForResult()); 176 EXPECT_EQ(net::OK, cb2.WaitForResult());
175 } 177 }
176 178
177 } // namespace blimp 179 } // namespace blimp
OLDNEW
« no previous file with comments | « blimp/net/tcp_engine_transport.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698