Issue 20347: Fix some focus traversal issues:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20347: Fix some focus traversal issues:... (Closed)

Created:
11 years, 10 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix some focus traversal issues: * When we're on the only focusable view, AdvanceFocus() should just focus us again. * When only one focusable view exists, FindLastFocusableView() should return it, not NULL. Also the code here was longer than it needed to be. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9759

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -11 lines)			Patch
	M	chrome/views/focus_manager.cc	View		2 chunks	+9 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcampan

11 years, 10 months ago (2009-02-13 17:17:16 UTC) #2

LGTM assuming you ran the focus manager unit-tests and the interactive UI tests
successfully with the change.

Expand Messages | Collapse Messages