Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 20347: Fix some focus traversal issues:... (Closed)

Created:
10 years, 6 months ago by Peter Kasting
Modified:
8 years, 3 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix some focus traversal issues: * When we're on the only focusable view, AdvanceFocus() should just focus us again. * When only one focusable view exists, FindLastFocusableView() should return it, not NULL. Also the code here was longer than it needed to be. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/views/focus_manager.cc View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
10 years, 6 months ago (2009-02-13 01:46:44 UTC) #1
jcampan
10 years, 6 months ago (2009-02-13 17:17:16 UTC) #2
LGTM assuming you ran the focus manager unit-tests and the interactive UI tests
successfully with the change.

Powered by Google App Engine
This is Rietveld 408576698