third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h ('K') | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

index bddf8ab959bda0fd893bd39a22beaca335608c66..7034b597155f4ce2ad33ad4391fb18a158b8ddf8 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

@@ -74,8 +74,8 @@ public:

void dispatchActivateEvent(int) override;

void dispatchExtendableMessageEvent(int eventID, const WebString& message, const WebSecurityOrigin& sourceOrigin, const WebMessagePortChannelArray&, const WebServiceWorkerClientInfo&) override;

void dispatchExtendableMessageEvent(int eventID, const WebString& message, const WebSecurityOrigin& sourceOrigin, const WebMessagePortChannelArray&, std::unique_ptr<WebServiceWorker::Handle>) override;

- void dispatchFetchEvent(int, const WebServiceWorkerRequest&) override;

- void dispatchForeignFetchEvent(int, const WebServiceWorkerRequest&) override;

+ void dispatchFetchEvent(int responseID, int eventFinishID, const WebServiceWorkerRequest&) override;

+ void dispatchForeignFetchEvent(int responseID, int eventFinishID, const WebServiceWorkerRequest&) override;

falken 2016/06/09 19:28:48 This naming seems inconsistent with the browsersid

shimazu 2016/06/10 10:26:49 Done. I think so too. I think the other eventIDs a

falken 2016/06/16 06:23:10 I'd like the fetch/foreignfetch names to be consis

shimazu 2016/06/21 02:43:37 Acknowledged.

void dispatchInstallEvent(int) override;

void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&, int actionIndex) override;

void dispatchNotificationCloseEvent(int, int64_t notificationID, const WebNotificationData&) override;