third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.h ('K') | « third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index 91d839fe67e4db8be531cf62cae607c5de9c154d..a83bbde72af5cee26ffcb580d4f81346ba0d7267 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -70,10 +70,11 @@ public:

virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult) = 0;

virtual void didHandleExtendableMessageEvent(int eventID, WebServiceWorkerEventResult) = 0;

- // Calling didHandleFetchEvent without response means no response was

+ // Calling respondFetchEvent without response means no response was

falken 2016/06/09 19:28:48 respondToFetchEvent

shimazu 2016/06/10 10:26:49 Done.

// provided by the service worker in the fetch events, so fallback to native.

- virtual void didHandleFetchEvent(int fetchEventID) = 0;

- virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) = 0;

+ virtual void respondToFetchEvent(int responseID) = 0;

+ virtual void respondToFetchEvent(int responseID, const WebServiceWorkerResponse&) = 0;

+ virtual void didHandleFetchEvent(int eventFinishID, WebServiceWorkerEventResult) = 0;

virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) = 0;

virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) = 0;

virtual void didHandleNotificationCloseEvent(int eventID, WebServiceWorkerEventResult) = 0;