content/browser/service_worker/service_worker_register_job.cc - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_metrics.cc ('k') | content/browser/service_worker/service_worker_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index e61f9e8a516d1b164bc606eaff5817ee85162039..fbfb635c3ba80d4e9cca356aca8b661f04c343b5 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -430,10 +430,12 @@ void ServiceWorkerRegisterJob::DispatchInstallEvent() {

ServiceWorkerMetrics::EventType::INSTALL,

base::Bind(&ServiceWorkerRegisterJob::OnInstallFailed,

weak_factory_.GetWeakPtr()));

- new_version()->DispatchEvent<ServiceWorkerHostMsg_InstallEventFinished>(

- request_id, ServiceWorkerMsg_InstallEvent(request_id),

- base::Bind(&ServiceWorkerRegisterJob::OnInstallFinished,

- weak_factory_.GetWeakPtr()));

+ new_version()

+ ->RegisterRequestCallback<ServiceWorkerHostMsg_InstallEventFinished>(

+ request_id, base::Bind(&ServiceWorkerRegisterJob::OnInstallFinished,

+ weak_factory_.GetWeakPtr()));

+ new_version()->DispatchEvent({request_id},

+ ServiceWorkerMsg_InstallEvent(request_id));

}

void ServiceWorkerRegisterJob::OnInstallFinished(