Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index eaf8071ffa4f87e00f6e4352b14509e80400d36f..07585564f47f1ef4c7e1859b4b4db11ddaa5cd13 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -67,6 +67,10 @@ std::string EventTypeToSuffix(ServiceWorkerMetrics::EventType event_type) {
return "_UNKNOWN";
case ServiceWorkerMetrics::EventType::FOREIGN_FETCH:
return "_FOREIGN_FETCH";
+ case ServiceWorkerMetrics::EventType::FETCH_WAITUNTIL:
+ return "_FETCH_WAITUNTIL";
+ case ServiceWorkerMetrics::EventType::FOREIGN_FETCH_WAITUNTIL:
+ return "_FOREIGN_FETCH_WAITUNTIL";
case ServiceWorkerMetrics::EventType::NUM_TYPES:
NOTREACHED() << static_cast<int>(event_type);
}
@@ -186,6 +190,10 @@ const char* ServiceWorkerMetrics::EventTypeToString(EventType event_type) {
return "Unknown";
case EventType::FOREIGN_FETCH:
return "Foreign Fetch";
+ case EventType::FETCH_WAITUNTIL:
+ return "Fetch WaitUntil";
+ case EventType::FOREIGN_FETCH_WAITUNTIL:
+ return "Foreign Fetch WaitUntil";
case EventType::NUM_TYPES:
break;
}
@@ -417,6 +425,10 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,
time);
}
break;
+ case EventType::FETCH_WAITUNTIL:
+ UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.FetchEvent.WaitUntil.Time",
+ time);
+ break;
case EventType::FOREIGN_FETCH:
if (was_handled) {
UMA_HISTOGRAM_MEDIUM_TIMES(
@@ -426,6 +438,10 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,
"ServiceWorker.ForeignFetchEvent.Fallback.Time", time);
}
break;
+ case EventType::FOREIGN_FETCH_WAITUNTIL:
+ UMA_HISTOGRAM_MEDIUM_TIMES(
+ "ServiceWorker.ForeignFetchEvent.WaitUntil.Time", time);
+ break;
case EventType::SYNC:
UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.BackgroundSyncEvent.Time",
time);
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.h ('k') | content/browser/service_worker/service_worker_register_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698