content/common/service_worker/service_worker_messages.h - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version_unittest.cc ('K') | « content/browser/service_worker/service_worker_version_unittest.cc ('k') | content/renderer/service_worker/service_worker_context_client.h » ('j') | content/renderer/service_worker/service_worker_context_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 05f22dfb46b64d799e5f77e0d9c32798ce9e4b7b..e77977ac0a85411d10dd0da5ffd6b0884ded1da3 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -253,10 +253,13 @@ IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_ActivateEventFinished,

IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_ExtendableMessageEventFinished,

int /* request_id */,

blink::WebServiceWorkerEventResult)

-IPC_MESSAGE_ROUTED3(ServiceWorkerHostMsg_FetchEventFinished,

+IPC_MESSAGE_ROUTED3(ServiceWorkerHostMsg_FetchEventResponse,

int /* request_id */,

falken 2016/06/16 06:23:11 response_id

shimazu 2016/06/21 02:43:38 Done.

content::ServiceWorkerFetchEventResult,

content::ServiceWorkerResponse)

+IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_FetchEventFinished,

+ int /* request_id */,

falken 2016/06/16 06:23:11 event_finish_id

shimazu 2016/06/21 02:43:38 Done.

+ blink::WebServiceWorkerEventResult)

IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_NotificationClickEventFinished,

int /* request_id */,

blink::WebServiceWorkerEventResult)

@@ -466,8 +469,9 @@ IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_ActivateEvent,

IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_ExtendableMessageEvent,

int /* request_id */,

ServiceWorkerMsg_ExtendableMessageEvent_Params)

-IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_FetchEvent,

- int /* request_id */,

+IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_FetchEvent,

+ int /* response_request_id */,

+ int /* finish_request_id */,

falken 2016/06/16 06:23:11 I think in your naming system, this is actually "i

shimazu 2016/06/21 02:43:38 Done.

content::ServiceWorkerFetchRequest)

IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_NotificationClickEvent,

int /* request_id */,