content/renderer/service_worker/service_worker_context_client.h - Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2034663002: ServiceWorker: Keep the worker alive until FetchEvent.waitUntil settles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_messages.h ('K') | « content/common/service_worker/service_worker_messages.h ('k') | content/renderer/service_worker/service_worker_context_client.cc » ('j') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.h

diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h

index e32a08108ab6015763f6220327d1bdd4af675736..29f2bae586dcfb01adcae6b08092b3eb2f92ae89 100644

--- a/content/renderer/service_worker/service_worker_context_client.h

+++ b/content/renderer/service_worker/service_worker_context_client.h

@@ -134,10 +134,12 @@ class ServiceWorkerContextClient

void didHandleInstallEvent(

int request_id,

blink::WebServiceWorkerEventResult result) override;

- void didHandleFetchEvent(int request_id) override;

- void didHandleFetchEvent(

+ void respondToFetchEvent(int request_id) override;

+ void respondToFetchEvent(

int request_id,

const blink::WebServiceWorkerResponse& response) override;

+ void didHandleFetchEvent(int request_id,

+ blink::WebServiceWorkerEventResult result) override;

falken 2016/06/16 06:23:11 WebServiceWorkerContextClient is using responseID

shimazu 2016/06/21 02:43:38 Done.

void didHandleNotificationClickEvent(

int request_id,

blink::WebServiceWorkerEventResult result) override;

@@ -197,7 +199,9 @@ class ServiceWorkerContextClient

int request_id,

const ServiceWorkerMsg_ExtendableMessageEvent_Params& params);

void OnInstallEvent(int request_id);

- void OnFetchEvent(int request_id, const ServiceWorkerFetchRequest& request);

+ void OnFetchEvent(int reseponse_request_id,

+ int finish_request_id,

falken 2016/06/16 06:23:11 Probably this should be response_id and event_fini

shimazu 2016/06/21 02:43:38 Done.

+ const ServiceWorkerFetchRequest& request);

void OnNotificationClickEvent(

int request_id,

int64_t persistent_notification_id,