Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2034633003: Revert of DrMemory: Disable AudioRendererSinkCacheTest.SmokeTest. (Closed)

Created:
4 years, 6 months ago by o1ka
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DrMemory: Disable AudioRendererSinkCacheTest.SmokeTest. (patchset #2 id:20001 of https://codereview.chromium.org/2024733002/ ) Reason for revert: Fix for timeout extension has landed https://codereview.chromium.org/2021273002, re-enabling the test. Original issue's description: > DrMemory: Disable AudioRendererSinkCacheTest.SmokeTest. > > BUG=615909 > TBR=olka@chromium.org > NOTRY=true > > Committed: https://crrev.com/a59bfc826308f7bb5abedf4106224daca03f646c > Cr-Commit-Position: refs/heads/master@{#396758} TBR=thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=615909 Committed: https://crrev.com/9af040a364c15bdc2adeea794e173a2c529a3ddc Cr-Commit-Position: refs/heads/master@{#397359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
o1ka
Created Revert of DrMemory: Disable AudioRendererSinkCacheTest.SmokeTest.
4 years, 6 months ago (2016-06-02 10:17:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034633003/1
4 years, 6 months ago (2016-06-02 10:18:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 10:55:52 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9af040a364c15bdc2adeea794e173a2c529a3ddc Cr-Commit-Position: refs/heads/master@{#397359}
4 years, 6 months ago (2016-06-02 10:57:24 UTC) #6
Lei Zhang
4 years, 6 months ago (2016-06-02 16:16:30 UTC) #7
Message was sent while issue was closed.
lgtm, hope it works. +current sheriff FYI

Powered by Google App Engine
This is Rietveld 408576698