Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2021273002: Extending timeout for AudioRendererSinkCacheTest.SmokeTest (Closed)

Created:
4 years, 6 months ago by o1ka
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, vanellope-cl_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extending timeout for AudioRendererSinkCacheTest.SmokeTest It accesses memory heavily, so it takes longer with DrMemory. BUG=615909 Committed: https://crrev.com/9bed9640236347f95a090060c024c549be198239 Cr-Commit-Position: refs/heads/master@{#397350}

Patch Set 1 #

Total comments: 1

Patch Set 2 : adding forgotten const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M content/renderer/media/audio_renderer_sink_cache_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/base/test_helpers.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M media/base/test_helpers.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
o1ka
tommi@, PTAL at another try :)
4 years, 6 months ago (2016-05-31 13:51:45 UTC) #2
o1ka
chcunningham@chromium.org: Please review changes in base/test
4 years, 6 months ago (2016-05-31 13:52:59 UTC) #4
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/2021273002/diff/1/media/base/test_helpers.h File media/base/test_helpers.h (right): https://codereview.chromium.org/2021273002/diff/1/media/base/test_helpers.h#newcode73 media/base/test_helpers.h:73: base::TimeDelta timeout_; const?
4 years, 6 months ago (2016-05-31 15:32:24 UTC) #5
chcunningham
lgtm
4 years, 6 months ago (2016-06-01 17:04:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021273002/20001
4 years, 6 months ago (2016-06-02 08:12:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 09:32:31 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:33:51 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9bed9640236347f95a090060c024c549be198239
Cr-Commit-Position: refs/heads/master@{#397350}

Powered by Google App Engine
This is Rietveld 408576698