Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 203463010: Remove "bashism" from plain shell script (Closed)

Created:
6 years, 9 months ago by davve
Modified:
6 years, 9 months ago
Reviewers:
szager, szager1
CC:
chromium-reviews, Ami GONE FROM CHROMIUM
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove "bashism" from plain shell script https://codereview.chromium.org/196413021 uses [[ which isn't present in all shells, particularly not dash which Debian uses as /bin/sh. Instead use two simple [ conditions. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/git-hooks/pre-commit View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
davve
I guess the question is if Chromium supports other shells than bash as /bin/sh. If ...
6 years, 9 months ago (2014-03-19 08:39:16 UTC) #1
Ami GONE FROM CHROMIUM
My $0.02: #!/bin/bash and done.
6 years, 9 months ago (2014-03-19 18:24:58 UTC) #2
szager1
On 2014/03/19 18:24:58, Ami Fischman wrote: > My $0.02: #!/bin/bash and done. My heart agrees, ...
6 years, 9 months ago (2014-03-19 19:17:17 UTC) #3
szager1
lgtm
6 years, 9 months ago (2014-03-19 19:17:29 UTC) #4
davve
The CQ bit was checked by davve@opera.com
6 years, 9 months ago (2014-03-20 07:38:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/203463010/1
6 years, 9 months ago (2014-03-20 07:38:44 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 07:40:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-20 07:40:13 UTC) #8
davve
The CQ bit was checked by davve@opera.com
6 years, 9 months ago (2014-03-20 13:50:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/203463010/1
6 years, 9 months ago (2014-03-20 13:50:35 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 17:33:44 UTC) #11
Message was sent while issue was closed.
Change committed as 258321

Powered by Google App Engine
This is Rietveld 408576698