[Cleanup] Factor out common code.

[Cleanup] Factor out common code.

Take code shared between TabManager and session restore,
put it in a central place.

BUG=none

[groby-ooo-7-16, 2016-06-02 01:44:42]

PTAL

[groby-ooo-7-16, 2016-06-02 01:45:05]

The CQ bit was checked by groby@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 01:46:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034573002/1

[commit-bot: I haz the power, 2016-06-02 02:00:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:00:03]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dan Beam, 2016-06-02 02:20:38]

i think you forgot to `git add chrome_pages_unittest.cc`

https://codereview.chromium.org/2034573002/diff/1/chrome/browser/ui/chrome_pa...
File chrome/browser/ui/chrome_pages.cc (right):

https://codereview.chromium.org/2034573002/diff/1/chrome/browser/ui/chrome_pa...
chrome/browser/ui/chrome_pages.cc:148: // memory to convert the URL prefix
constants into std::strings.
why do we have to avoid this?  because it's called from memory-sensitive code?

https://codereview.chromium.org/2034573002/diff/1/chrome/browser/ui/chrome_pa...
chrome/browser/ui/chrome_pages.cc:152: return true;
culies?

https://codereview.chromium.org/2034573002/diff/1/chrome/browser/ui/chrome_pa...
chrome/browser/ui/chrome_pages.cc:153: }
i don't really think this for loop of 4 entries is buying us much

[Dan Beam, 2016-06-02 02:20:49]

https://codereview.chromium.org/2034573002/diff/1/chrome/browser/ui/chrome_pa...
File chrome/browser/ui/chrome_pages.cc (right):

https://codereview.chromium.org/2034573002/diff/1/chrome/browser/ui/chrome_pa...
chrome/browser/ui/chrome_pages.cc:152: return true;
On 2016/06/02 02:20:38, Dan Beam wrote:
> culies?

curlies*

[Dan Beam, 2016-06-02 02:22:41]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-06-02 02:22:42]

why can't we just use contents->GetBrowserContext() instead of passing the URL
from |contents|?

https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...

[groby-ooo-7-16, 2016-06-02 19:17:53]

Description was changed from

==========
[Cleanup] Factor out common code.

Take code shared between TabManager and session restore,
put it in a central place.

BUG=none
==========

to

==========
[Cleanup] Factor out common code.

Take code shared between TabManager and session restore,
put it in a central place.

BUG=none
==========

[groby-ooo-7-16, 2016-06-02 19:17:53]

groby@chromium.org changed reviewers:
+ sky@chromium.org

[groby-ooo-7-16, 2016-06-02 19:20:07]

sky:PTAL 

On 2016/06/02 02:22:42, Dan Beam wrote:
> why can't we just use contents->GetBrowserContext() instead of passing the URL
> from |contents|?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...

Because this is a pure code move. contents will require rewriting. I can't right
now. happy to abandon the CL if you think that's a blocker.

[Dan Beam, 2016-06-02 19:35:10]

On 2016/06/02 19:20:07, groby wrote:
> sky:PTAL 
> 
> On 2016/06/02 02:22:42, Dan Beam wrote:
> > why can't we just use contents->GetBrowserContext() instead of passing the
URL
> > from |contents|?
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...
> 
> Because this is a pure code move. contents will require rewriting. I can't
right
> now. happy to abandon the CL if you think that's a blocker.

happy to review when you have time to make this code less silly ;)

[Dan Beam, 2016-06-02 19:35:44]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[sky, 2016-06-02 21:46:39]

https://codereview.chromium.org/2034573002/diff/20001/chrome/browser/ui/chrom...
File chrome/browser/ui/chrome_pages.h (right):

https://codereview.chromium.org/2034573002/diff/20001/chrome/browser/ui/chrom...
chrome/browser/ui/chrome_pages.h:41: bool IsInternalPage(const GURL& url);
'Internal' is confusing here. Why isn't chrome://omnibox considered 'internal'?