chrome/browser/ui/chrome_pages_unittest.cc - Issue 2034573002: [Cleanup] Factor out common code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/chrome_pages_unittest.cc

Issue 2034573002: [Cleanup] Factor out common code. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Wherein we relearn that "commit -a" doesn't add new files. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #include "chrome/browser/ui/chrome_pages.h"

	5

	6 #include "chrome/common/url_constants.h"

	7 #include "testing/gtest/include/gtest/gtest.h"

	8

	9 TEST(ChromePagesTest, IsInternalPage) {

	10 EXPECT_TRUE(chrome::IsInternalPage(GURL(chrome::kChromeUIDownloadsURL)));

	11 EXPECT_TRUE(chrome::IsInternalPage(GURL(chrome::kChromeUIHistoryURL)));

	12 EXPECT_TRUE(chrome::IsInternalPage(GURL(chrome::kChromeUINewTabURL)));

	13 EXPECT_TRUE(chrome::IsInternalPage(GURL(chrome::kChromeUISettingsURL)));

	14

	15 // Debugging URLs are not included.

	16 #if defined(OS_CHROMEOS)

	17 EXPECT_FALSE(chrome::IsInternalPage(GURL(chrome::kChromeUIDiscardsURL)));

	18 #endif

	19 EXPECT_FALSE(

	20 chrome::IsInternalPage(GURL(chrome::kChromeUINetInternalsURL)));

	21

	22 // Prefix matches are included.

	23 EXPECT_TRUE(

	24 chrome::IsInternalPage(GURL("chrome://settings/fakeSetting")));

	25 }

OLD	NEW