[DevTools] Add removeFunction to EventListener protocol object

[DevTools] Add removeFunction to EventListener protocol object

With this change CommandLineAPI getEventListeners and protocol getEventListeners methods use the same way to provide remove function. One redundant roundtrip is removed from frontend side.

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e
Cr-Commit-Position: refs/heads/master@{#397406}

[kozy, 2016-06-01 23:19:45]

Dmitry, please take a look!

[dgozman, 2016-06-01 23:54:05]

lgtm

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
(right):

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:108:
EventListenerVector* listeners = target->getEventListeners(eventTypes[j]);
Just getEventListeners(type)

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:117:
V8AbstractEventListener* v8Listener =
static_cast<V8AbstractEventListener*>(current);
V8AbstractEventListener::cast(current) and check for null.

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:138:
static v8::MaybeLocal<v8::Function> removeFunction(v8::Local<v8::Context>
context, v8::Local<v8::Value> object, v8::Local<v8::Object> handler,
AtomicString type, bool useCapture)
createRemoveFunction

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:830:
func.call(null, type, listener, useCapture, passive);
Let's use |this| instead of |func|.

[kozy, 2016-06-02 01:04:39]

All done!

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
(right):

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:108:
EventListenerVector* listeners = target->getEventListeners(eventTypes[j]);
On 2016/06/01 23:54:05, dgozman wrote:
> Just getEventListeners(type)

Done.

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:117:
V8AbstractEventListener* v8Listener =
static_cast<V8AbstractEventListener*>(current);
On 2016/06/01 23:54:05, dgozman wrote:
> V8AbstractEventListener::cast(current) and check for null.

Done.

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:138:
static v8::MaybeLocal<v8::Function> removeFunction(v8::Local<v8::Context>
context, v8::Local<v8::Value> object, v8::Local<v8::Object> handler,
AtomicString type, bool useCapture)
On 2016/06/01 23:54:05, dgozman wrote:
> createRemoveFunction

Done.

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2034533002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:830:
func.call(null, type, listener, useCapture, passive);
On 2016/06/01 23:54:05, dgozman wrote:
> Let's use |this| instead of |func|.

Done.

[kozy, 2016-06-02 01:05:07]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-06-02 01:05:07]

Pavel, please take a look!
I need owner lgtm for bindings.

[pfeldman, 2016-06-02 01:08:48]

lgtm

[kozy, 2016-06-02 01:15:53]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-06-02 01:15:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2034533002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-06-02 01:17:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034533002/20001

[commit-bot: I haz the power, 2016-06-02 02:04:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:04:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kozy, 2016-06-02 02:16:43]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:17:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034533002/20001

[commit-bot: I haz the power, 2016-06-02 02:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:38:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kozy, 2016-06-02 04:01:46]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-06-02 04:02:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034533002/20001

[commit-bot: I haz the power, 2016-06-02 04:21:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 04:21:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kozy, 2016-06-02 13:33:07]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-06-02 13:33:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034533002/20001

[commit-bot: I haz the power, 2016-06-02 15:10:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-02 15:12:31]

Description was changed from

==========
[DevTools] Add removeFunction to EventListener protocol object

With this change CommandLineAPI getEventListeners and protocol getEventListeners
methods use the same way to provide remove function. One redundant roundtrip is
removed from frontend side.

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Add removeFunction to EventListener protocol object

With this change CommandLineAPI getEventListeners and protocol getEventListeners
methods use the same way to provide remove function. One redundant roundtrip is
removed from frontend side.

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e
Cr-Commit-Position: refs/heads/master@{#397406}
==========

[commit-bot: I haz the power, 2016-06-02 15:12:32]

Patchset 2 (id:??) landed as
https://crrev.com/45ecc4451be879bc38d54903401ab30ef18a566e
Cr-Commit-Position: refs/heads/master@{#397406}