third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h - Issue 2034533002: [DevTools] Add removeFunction to EventListener protocol object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h

Issue 2034533002: [DevTools] Add removeFunction to EventListener protocol object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery2-expected.txt ('k') | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h

index 3cb533bba6f1e886f3ce25c2a9debb409931385d..87612e2b4a39bb6b2aaa1473b3b74d8912ee23c0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h

@@ -14,11 +14,12 @@ namespace blink {

class V8EventListenerInfo {

public:

- V8EventListenerInfo(AtomicString eventType, bool useCapture, bool passive, v8::Local<v8::Object> handler)

+ V8EventListenerInfo(AtomicString eventType, bool useCapture, bool passive, v8::Local<v8::Object> handler, v8::MaybeLocal<v8::Function> removeFunction)

: eventType(eventType)

, useCapture(useCapture)

, passive(passive)

, handler(handler)

+ , removeFunction(removeFunction)

{

}

@@ -26,7 +27,7 @@ public:

bool useCapture;

bool passive;

v8::Local<v8::Object> handler;

+ v8::MaybeLocal<v8::Function> removeFunction;

};

using V8EventListenerInfoList = Vector<V8EventListenerInfo>;