Adding mac support for Remoting host GN builds.

Adding mac support for Remoting host GN builds.

BUG=611859
R=sergeyu@chromium.org

Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5
Committed: https://crrev.com/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355
Cr-Original-Commit-Position: refs/heads/master@{#399731}
Cr-Commit-Position: refs/heads/master@{#399957}

[nicholss, 2016-06-09 21:23:22]

I guess this did not send?

[Sergey Ulanov, 2016-06-09 23:37:31]

Hopefully we will be able to remove all the GYP files. Exciting!

https://codereview.chromium.org/2034513002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (left):

https://codereview.chromium.org/2034513002/diff/1/remoting/host/BUILD.gn#oldc...
remoting/host/BUILD.gn:204: # TODO(GYP) Mac host_bundle_name and
prefpane_bundle_name.
If I understand correctly this comment is the reason you added version.h.in. But
the GN still need to load these parameters as me2me_host_bundle_name. You fixed
remoting_version.gni to invoke python only once, which is great. But as long as
we still load these in GN it's better to pass them to the build using defines
instead of generated header.

https://codereview.chromium.org/2034513002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/2034513002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:709: # TODO(GYP) More Windows remoting targets from
remoting_host_win.gypi
This is an outdated TODO. Please remove.

https://codereview.chromium.org/2034513002/diff/20001/remoting/remoting_enabl...
File remoting/remoting_enable.gni (right):

https://codereview.chromium.org/2034513002/diff/20001/remoting/remoting_enabl...
remoting/remoting_enable.gni:17: if (is_win || (is_linux && !is_chromeos &&
use_x11)) {
just add is_mac here

[nicholss, 2016-06-10 16:40:31]

https://codereview.chromium.org/2034513002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (left):

https://codereview.chromium.org/2034513002/diff/1/remoting/host/BUILD.gn#oldc...
remoting/host/BUILD.gn:204: # TODO(GYP) Mac host_bundle_name and
prefpane_bundle_name.
On 2016/06/09 23:37:30, Sergey Ulanov wrote:
> If I understand correctly this comment is the reason you added version.h.in.
But
> the GN still need to load these parameters as me2me_host_bundle_name. You
fixed
> remoting_version.gni to invoke python only once, which is great. But as long
as
> we still load these in GN it's better to pass them to the build using defines
> instead of generated header.

They are set by importing on remoting_versiong.gni and a bit of magic from
//build/util/version.py

So I think this is ok.

https://codereview.chromium.org/2034513002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/2034513002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:9: import("//chrome/version.gni")
See this file for where some of the old vars had been set:

```
prefpane_bundle_name = _result.prefpane_bundle_name
host_bundle_name = _result.host_bundle_name
me2me_host_bundle_name = _result.mac_host_bundle
native_messaging_host_bundle_name = _result.mac_native_messaging_bundle
remote_assistance_host_bundle_name = _result.mac_remote_assistance_bundle
```

https://codereview.chromium.org/2034513002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:709: # TODO(GYP) More Windows remoting targets from
remoting_host_win.gypi
On 2016/06/09 23:37:30, Sergey Ulanov wrote:
> This is an outdated TODO. Please remove.

Done.

https://codereview.chromium.org/2034513002/diff/20001/remoting/remoting_enabl...
File remoting/remoting_enable.gni (right):

https://codereview.chromium.org/2034513002/diff/20001/remoting/remoting_enabl...
remoting/remoting_enable.gni:17: if (is_win || (is_linux && !is_chromeos &&
use_x11)) {
On 2016/06/09 23:37:30, Sergey Ulanov wrote:
> just add is_mac here

Done.

[nicholss, 2016-06-10 21:38:36]

PTAL

[Sergey Ulanov, 2016-06-13 23:36:17]

lgtm

https://codereview.chromium.org/2034513002/diff/80001/remoting/BUILD.gn
File remoting/BUILD.gn (right):

https://codereview.chromium.org/2034513002/diff/80001/remoting/BUILD.gn#newco...
remoting/BUILD.gn:13: # Various remoting targets need this version definition.
Add TODO here to move this to version.h.in

[nicholss, 2016-06-13 23:40:02]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2016-06-13 23:40:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034513002/80001

[nicholss, 2016-06-13 23:40:55]

The CQ bit was unchecked by nicholss@chromium.org

[nicholss, 2016-06-13 23:44:18]

https://codereview.chromium.org/2034513002/diff/80001/remoting/BUILD.gn
File remoting/BUILD.gn (right):

https://codereview.chromium.org/2034513002/diff/80001/remoting/BUILD.gn#newco...
remoting/BUILD.gn:13: # Various remoting targets need this version definition.
On 2016/06/13 23:36:16, Sergey Ulanov wrote:
> Add TODO here to move this to version.h.in

Done.

[nicholss, 2016-06-13 23:44:26]

The CQ bit was checked by nicholss@chromium.org

[nicholss, 2016-06-13 23:44:27]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2034513002/#ps100001
(title: "Adding todo.")

[nicholss, 2016-06-13 23:44:27]

The CQ bit was unchecked by nicholss@chromium.org

[nicholss, 2016-06-14 16:16:03]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2016-06-14 16:16:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034513002/100001

[commit-bot: I haz the power, 2016-06-14 17:13:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-14 17:13:18]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 17:14:42]

Description was changed from

==========
Adding mac support for Remoting host GN builds.

BUG=611859

R=sergeyu@chromium.org
==========

to

==========
Adding mac support for Remoting host GN builds.

BUG=611859

R=sergeyu@chromium.org

Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5
Cr-Commit-Position: refs/heads/master@{#399731}
==========

[commit-bot: I haz the power, 2016-06-14 17:14:43]

Patchset 6 (id:??) landed as
https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5
Cr-Commit-Position: refs/heads/master@{#399731}

[hcarmona, 2016-06-14 17:52:56]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2068633003/ by hcarmona@chromium.org.

The reason for reverting is: Suspecting this CL for compile failure in Mac GN:

https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/build...

Undefined symbols for architecture x86_64:
  "_GetApplicationEventTarget", referenced from:
      remoting::(anonymous namespace)::SessionWatcher::InstallEventHandler() in
libhost.a(curtain_mode_mac.o)
  "_InstallEventHandler", referenced from:
      remoting::(anonymous namespace)::SessionWatcher::InstallEventHandler() in
libhost.a(curtain_mode_mac.o)
  "_RemoveEventHandler", referenced from:
      remoting::(anonymous namespace)::SessionWatcher::RemoveEventHandler() in
libhost.a(curtain_mode_mac.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
.

[nicholss, 2016-06-14 22:36:06]

Description was changed from

==========
Adding mac support for Remoting host GN builds.

BUG=611859

R=sergeyu@chromium.org

Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5
Cr-Commit-Position: refs/heads/master@{#399731}
==========

to

==========
Adding mac support for Remoting host GN builds.

BUG=611859

R=sergeyu@chromium.org

Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5
Cr-Commit-Position: refs/heads/master@{#399731}
==========

[nicholss, 2016-06-15 16:42:16]

The CQ bit was checked by nicholss@chromium.org

[nicholss, 2016-06-15 16:42:17]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2034513002/#ps160001
(title: "Adding Carbon.framework")

[commit-bot: I haz the power, 2016-06-15 16:42:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034513002/160001

[commit-bot: I haz the power, 2016-06-15 18:11:18]

Description was changed from

==========
Adding mac support for Remoting host GN builds.

BUG=611859

R=sergeyu@chromium.org

Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5
Cr-Commit-Position: refs/heads/master@{#399731}
==========

to

==========
Adding mac support for Remoting host GN builds.

BUG=611859

R=sergeyu@chromium.org

Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5
Cr-Commit-Position: refs/heads/master@{#399731}
==========

[commit-bot: I haz the power, 2016-06-15 18:11:20]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-06-15 18:13:13]

Description was changed from

==========
Adding mac support for Remoting host GN builds.

BUG=611859

R=sergeyu@chromium.org

Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5
Cr-Commit-Position: refs/heads/master@{#399731}
==========

to

==========
Adding mac support for Remoting host GN builds.

BUG=611859

R=sergeyu@chromium.org

Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5
Committed: https://crrev.com/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355
Cr-Original-Commit-Position: refs/heads/master@{#399731}
Cr-Commit-Position: refs/heads/master@{#399957}
==========

[commit-bot: I haz the power, 2016-06-15 18:13:15]

Patchset 9 (id:??) landed as
https://crrev.com/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355
Cr-Commit-Position: refs/heads/master@{#399957}