remoting/remoting_version.gni - Issue 2034513002: Adding mac support for Remoting host GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/remoting_version.gni

Issue 2034513002: Adding mac support for Remoting host GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding Carbon.framework Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/remoting_version.gni

diff --git a/remoting/remoting_version.gni b/remoting/remoting_version.gni

index ac96c9ebf377b038b8e9fecb4beda00be0d8218e..cdf97fa98f469463092048352be1f183807176fa 100644

--- a/remoting/remoting_version.gni

+++ b/remoting/remoting_version.gni

@@ -23,20 +23,20 @@ _remoting_version_path = rebase_path(_remoting_version_abspath, root_build_dir)

_remoting_branding_path =

rebase_path(_remoting_branding_abspath, root_build_dir)

-prefpane_bundle_name = exec_script(_version_py_abspath,

- [

- "-f",

- _remoting_branding_path,

- "-t \"@MAC_PREFPANE_BUNDLE_NAME@\"",

- ],

- "string",

- remoting_version_files)

+_branding_dictionary_template = "mac_host_bundle = \"@MAC_HOST_BUNDLE_NAME@\" " + "mac_native_messaging_bundle = \"@MAC_NATIVE_MESSAGING_HOST_BUNDLE_NAME@\" " + "mac_remote_assistance_bundle = \"@MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_NAME@\" " + "prefpane_bundle_name = \"@MAC_PREFPANE_BUNDLE_NAME@\" " + "host_bundle_name = \"@MAC_HOST_BUNDLE_NAME@\" "

-host_bundle_name = exec_script(_version_py_abspath,

- [

- "-f",

- _remoting_branding_path,

- "-t \"@MAC_HOST_BUNDLE_NAME@\"",

- ],

- "string",

- remoting_version_files)

+_result = exec_script(_version_py_abspath,

+ [

+ "-f",

+ _remoting_branding_path,

+ "-t",

+ _branding_dictionary_template,

+ ],

+ "scope",

+ remoting_version_files)

+prefpane_bundle_name = _result.prefpane_bundle_name

+host_bundle_name = _result.host_bundle_name

+me2me_host_bundle_name = _result.mac_host_bundle

+native_messaging_host_bundle_name = _result.mac_native_messaging_bundle

+remote_assistance_host_bundle_name = _result.mac_remote_assistance_bundle

« no previous file with comments | « remoting/remoting_enable.gni ('k') | no next file » | no next file with comments »