Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2034423002: Improve the HeapListHashSet no-weakness static assert message. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve the HeapListHashSet no-weakness static assert message. Mention the alternate HeapLinkedHashSet<> if WeakMember<>s are attempted used with HeapListHashSet<>; for non-trivial reasons, we only support weakness with the former. R= BUG=614112 Committed: https://crrev.com/d92a7020941c8db2b4d1d36e30dc8b99c09c6f7c Cr-Commit-Position: refs/heads/master@{#397999}

Patch Set 1 #

Patch Set 2 : add Heap name prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/wtf/ListHashSet.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-06 05:26:49 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-06 05:27:34 UTC) #3
Yuta Kitamura
lgtm
4 years, 6 months ago (2016-06-06 05:30:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034423002/20001
4 years, 6 months ago (2016-06-06 05:35:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 09:54:00 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 09:55:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d92a7020941c8db2b4d1d36e30dc8b99c09c6f7c
Cr-Commit-Position: refs/heads/master@{#397999}

Powered by Google App Engine
This is Rietveld 408576698