Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: third_party/WebKit/Source/wtf/ListHashSet.h

Issue 2034423002: Improve the HeapListHashSet no-weakness static assert message. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add Heap name prefix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/ListHashSet.h
diff --git a/third_party/WebKit/Source/wtf/ListHashSet.h b/third_party/WebKit/Source/wtf/ListHashSet.h
index f819061294994fb32f7f8eff11952cecf769e60a..54aded529e3210ef874dacc7ec394872a8d23a41 100644
--- a/third_party/WebKit/Source/wtf/ListHashSet.h
+++ b/third_party/WebKit/Source/wtf/ListHashSet.h
@@ -1026,7 +1026,7 @@ template <typename T, size_t inlineCapacity, typename U, typename V>
template <typename VisitorDispatcher>
void ListHashSet<T, inlineCapacity, U, V>::trace(VisitorDispatcher visitor)
{
- static_assert(HashTraits<T>::weakHandlingFlag == NoWeakHandlingInCollections, "ListHashSet does not support weakness");
+ static_assert(HashTraits<T>::weakHandlingFlag == NoWeakHandlingInCollections, "HeapListHashSet does not support weakness, consider using HeapLinkedHashSet instead.");
// This marks all the nodes and their contents live that can be accessed
// through the HashTable. That includes m_head and m_tail so we do not have
// to explicitly trace them here.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698