Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use ReadWriteLock, add comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 7783a262a27b36201331f3184c5823e7e952f6f8..c598413d5eab49d648ddb7a7ae19fefc31ae165e 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -911,6 +911,10 @@ void RenderFrameHostImpl::OnAddMessageToConsole(
if (delegate_->AddMessageToConsole(level, message, line_no, source_id))
return;
+ // In order for CSP violation detections in the tests to work, console
+ // messages must be forwarded to logging::LogMessage().
+ // Ref: https://crrev.com/2013573007/
grt (UTC plus 2) 2016/08/15 07:36:32 i think it's better to link to a bug rather than a
wychen 2016/08/17 17:08:54 Neither of the existing bugs in that CL is good. I
grt (UTC plus 2) 2016/08/18 08:09:33 Perfect. Please put this issue number in the "BUG=
wychen 2016/08/18 08:50:30 Done.
+
// Pass through log level only on WebUI pages to limit console spew.
const bool is_web_ui =
HasWebUIScheme(delegate_->GetMainFrameLastCommittedURL());

Powered by Google App Engine
This is Rietveld 408576698