Allow multiple logging::LogMessage{Handler,Listener}s

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 893 matching lines @@
 }
 
 void RenderFrameHostImpl::OnAddMessageToConsole(
     int32_t level,
     const base::string16& message,
     int32_t line_no,
     const base::string16& source_id) {
   if (delegate_->AddMessageToConsole(level, message, line_no, source_id))
     return;
 
+  // In order for CSP violation detections in the tests to work, console
+  // messages must be forwarded to logging::LogMessage().
+  // Ref: https://crrev.com/2013573007/

[grt (UTC plus 2), 2016/08/15 07:36:32]

i think it's better to link to a bug rather than a code review. is
https://crbug.com/616181 appropriate here?

[wychen, 2016/08/17 17:08:54]

Neither of the existing bugs in that CL is good.
I've created a new one.

[grt (UTC plus 2), 2016/08/18 08:09:33]

Perfect. Please put this issue number in the "BUG=" line of the CL description
as well. Thanks.

[wychen, 2016/08/18 08:50:30]

Done.

+
   // Pass through log level only on WebUI pages to limit console spew.
   const bool is_web_ui =
       HasWebUIScheme(delegate_->GetMainFrameLastCommittedURL());
   const int32_t resolved_level = is_web_ui ? level : ::logging::LOG_INFO;
 
   // LogMessages can be persisted so this shouldn't be logged in incognito mode.
   // This rule is not applied to WebUI pages, because source code of WebUI is a
   // part of Chrome source code, and we want to treat messages from WebUI the
   // same way as we treat log messages from native code.
   if (::logging::GetMinLogLevel() <= resolved_level &&
@@ skipping 2111 matching lines @@
   web_bluetooth_service_->SetClientConnectionErrorHandler(base::Bind(
       &RenderFrameHostImpl::DeleteWebBluetoothService, base::Unretained(this)));
   return web_bluetooth_service_.get();
 }
 
 void RenderFrameHostImpl::DeleteWebBluetoothService() {
   web_bluetooth_service_.reset();
 }
 
 }  // namespace content