components/crash/content/app/breakpad_mac.mm - Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/breakpad_mac.mm

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments, format Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/crash/content/app/breakpad_mac.mm

diff --git a/components/crash/content/app/breakpad_mac.mm b/components/crash/content/app/breakpad_mac.mm

index 6c6934bfa7ea832e707bcdbaef9ceab1cdf0ebff..47caf728ce6b0b50ab47fd60b6572d774e2bf7f4 100644

--- a/components/crash/content/app/breakpad_mac.mm

+++ b/components/crash/content/app/breakpad_mac.mm

@@ -264,7 +264,7 @@ void InitCrashReporter(const std::string& process_type) {

SetCrashKeyValue(@"prod", [info_dictionary objectForKey:@BREAKPAD_PRODUCT]);

SetCrashKeyValue(@"plat", @"OS X");

- logging::SetLogMessageHandler(&FatalMessageHandler);

+ logging::PushLogMessageHandler(&FatalMessageHandler);

base::debug::SetDumpWithoutCrashingFunction(&DumpHelper::DumpWithoutCrashing);

// abort() sends SIGABRT, which breakpad does not intercept.