chrome/test/chromedriver/logging.cc - Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/logging.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments, format Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/logging.cc

diff --git a/chrome/test/chromedriver/logging.cc b/chrome/test/chromedriver/logging.cc

index 67f60e4acff040e479f71ccc41daaa2c4ebed961..9675cedda453eace7ea0567a558b4ae192069927 100644

--- a/chrome/test/chromedriver/logging.cc

+++ b/chrome/test/chromedriver/logging.cc

@@ -237,7 +237,7 @@ bool InitLogging() {

false, // enable_thread_id

false, // enable_timestamp

false); // enable_tickcount

- logging::SetLogMessageHandler(&HandleLogMessage);

+ logging::PushLogMessageHandler(&HandleLogMessage);

logging::LoggingSettings logging_settings;

logging_settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;