Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: third_party/crashpad/crashpad/util/thread/thread_log_messages.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix installation_validator_unittest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
diff --git a/third_party/crashpad/crashpad/util/thread/thread_log_messages.cc b/third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
index 7f67e458379bdda2a73498f1c7cbe28d05113b20..686ac24979fc0e44bdfa7421bff755fc608b621c 100644
--- a/third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
+++ b/third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
@@ -41,19 +41,18 @@ class ThreadLogMessagesMaster {
tls_.Initialize(nullptr);
DCHECK(tls_.initialized());
- DCHECK(!logging::GetLogMessageHandler());
- logging::SetLogMessageHandler(LogMessageHandler);
+ logging::PushLogMessageHandler(LogMessageHandler);
}
~ThreadLogMessagesMaster() {
- DCHECK_EQ(logging::GetLogMessageHandler(), LogMessageHandler);
- logging::SetLogMessageHandler(nullptr);
+ DCHECK_EQ(logging::GetTopLogMessageHandler(), LogMessageHandler);
+ logging::PopLogMessageHandler();
tls_.Free();
}
void SetThreadMessageList(std::vector<std::string>* message_list) {
- DCHECK_EQ(logging::GetLogMessageHandler(), LogMessageHandler);
+ DCHECK_EQ(logging::GetTopLogMessageHandler(), LogMessageHandler);
DCHECK_NE(tls_.Get() != nullptr, message_list != nullptr);
tls_.Set(message_list);
}

Powered by Google App Engine
This is Rietveld 408576698