remoting/client/plugin/chromoting_instance.cc - Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/chromoting_instance.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix installation_validator_unittest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/plugin/chromoting_instance.cc

diff --git a/remoting/client/plugin/chromoting_instance.cc b/remoting/client/plugin/chromoting_instance.cc

index 90db58344b3f2324574d56baa893dca5d9181a33..156feb290bfe4057b7506fc2a0037bb2b468d674 100644

--- a/remoting/client/plugin/chromoting_instance.cc

+++ b/remoting/client/plugin/chromoting_instance.cc

@@ -1034,7 +1034,7 @@ void ChromotingInstance::RegisterLogMessageHandler() {

// Set up log message handler.

// This is not thread-safe so we need it within our lock.

- logging::SetLogMessageHandler(&LogToUI);

+ logging::PushLogMessageHandler(&LogToUI);

Dan Beam 2016/06/09 18:52:50 does this call ever need to be balanced by a PopLo

wychen 2016/06/09 21:04:17 I was a bit curious when I changed this. The handl

}

void ChromotingInstance::RegisterLoggingInstance() {

« no previous file with comments | « net/tools/stress_cache/stress_cache.cc ('k') | remoting/host/logging_mac.cc » ('j') | no next file with comments »