remoting/host/native_messaging/log_message_handler.h - Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/native_messaging/log_message_handler.h

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix installation_validator_unittest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/native_messaging/log_message_handler.h

diff --git a/remoting/host/native_messaging/log_message_handler.h b/remoting/host/native_messaging/log_message_handler.h

index 201c7ba77cf9df592ece0827b0a17e79bfcbaa82..6c093448a85716e002e2704cf7c481bc2fcb3fd9 100644

--- a/remoting/host/native_messaging/log_message_handler.h

+++ b/remoting/host/native_messaging/log_message_handler.h

@@ -15,7 +15,7 @@

namespace remoting {

-// Helper class for logging::SetLogMessageHandler to deliver log messages to

+// Helper class for logging::PushLogMessageHandler to deliver log messages to

// a consistent thread in a thread-safe way and in a format suitable for sending

// over a Native Messaging channel.

class LogMessageHandler {

@@ -41,7 +41,6 @@ class LogMessageHandler {

Delegate delegate_;

bool suppress_logging_;

scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner_;

- logging::LogMessageHandlerFunction previous_log_message_handler_;

base::WeakPtrFactory<LogMessageHandler> weak_ptr_factory_;

};