ios/chrome/browser/crash_report/breakpad_helper.mm - Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/crash_report/breakpad_helper.mm

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix installation_validator_unittest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/crash_report/breakpad_helper.mm

diff --git a/ios/chrome/browser/crash_report/breakpad_helper.mm b/ios/chrome/browser/crash_report/breakpad_helper.mm

index 252df3da7c5b61499a37109909f392706885147d..fe741875caf9fc17628adffc43302e3b0fb565b1 100644

--- a/ios/chrome/browser/crash_report/breakpad_helper.mm

+++ b/ios/chrome/browser/crash_report/breakpad_helper.mm

@@ -78,7 +78,7 @@ void ClearCrashKeyValueImpl(const base::StringPiece& key) {

RemoveReportParameter(base::SysUTF8ToNSString(key.as_string()));

}

-// Callback for logging::SetLogMessageHandler

+// Callback for logging::PushLogMessageHandler

bool FatalMessageHandler(int severity,

const char* file,

int line,

@@ -130,7 +130,7 @@ void Start(const std::string& channel_name) {

[[BreakpadController sharedInstance] start:YES];

base::debug::SetCrashKeyReportingFunctions(&SetCrashKeyValueImpl,

&ClearCrashKeyValueImpl);

- logging::SetLogMessageHandler(&FatalMessageHandler);

+ logging::PushLogMessageHandler(&FatalMessageHandler);

g_crash_reporter_enabled = true;

// Register channel information.

if (channel_name.length()) {