chrome/test/base/web_ui_browser_test.cc - Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/web_ui_browser_test.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix installation_validator_unittest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/web_ui_browser_test.cc

diff --git a/chrome/test/base/web_ui_browser_test.cc b/chrome/test/base/web_ui_browser_test.cc

index 4a55e86fc2e041d9b37aca86663e4c6dc6f2a426..e43ff638d6c239b1250bde8e90507267150f327a 100644

--- a/chrome/test/base/web_ui_browser_test.cc

+++ b/chrome/test/base/web_ui_browser_test.cc

@@ -372,7 +372,7 @@ base::LazyInstance<MockWebUIProvider> mock_provider_ =

void WebUIBrowserTest::SetUpOnMainThread() {

JavaScriptBrowserTest::SetUpOnMainThread();

- logging::SetLogMessageHandler(&LogHandler);

+ logging::PushLogMessageHandler(&LogHandler);

AddLibrary(base::FilePath(kA11yAuditLibraryJSPath));

@@ -390,7 +390,7 @@ void WebUIBrowserTest::SetUpOnMainThread() {

}

void WebUIBrowserTest::TearDownOnMainThread() {

- logging::SetLogMessageHandler(NULL);

+ logging::PopLogMessageHandler();

test_factory_->RemoveFactoryOverride(GURL(kDummyURL).host());

content::WebUIControllerFactory::UnregisterFactoryForTesting(