chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc - Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix installation_validator_unittest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc b/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

index 8ffe5a7498ecadb9be46dd12587910f683638c3f..39adffacb364eaaeece159a77a53f78f17ddcae3 100644

--- a/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

@@ -42,10 +42,10 @@ bool HandleMessage(int severity,

class NewTabUIBrowserTest : public InProcessBrowserTest {

public:

NewTabUIBrowserTest() {

- logging::SetLogMessageHandler(&HandleMessage);

+ logging::PushLogMessageHandler(&HandleMessage);

}

- ~NewTabUIBrowserTest() override { logging::SetLogMessageHandler(NULL); }

+ ~NewTabUIBrowserTest() override { logging::PopLogMessageHandler(); }

void TearDown() override {

InProcessBrowserTest::TearDown();