Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: components/test_runner/test_runner.cc

Issue 2034393003: testRunner.layoutAndPaintAsyncThen ==> testRunner.compositeAsyncThen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/pixel_dump.cc ('k') | components/test_runner/test_runner.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 7d1b8334f72e0d224f341e6f0ee84fa75c32c41d..ae6808112a6641d68f678ead33b3a611b5f24c9e 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -15,7 +15,7 @@
#include "base/strings/stringprintf.h"
#include "build/build_config.h"
#include "components/test_runner/app_banner_client.h"
-#include "components/test_runner/layout_and_paint_async_then.h"
+#include "components/test_runner/composite_async_then.h"
#include "components/test_runner/layout_dump.h"
#include "components/test_runner/mock_content_settings_client.h"
#include "components/test_runner/mock_credential_manager_client.h"
@@ -121,6 +121,7 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
void ClearAllDatabases();
void ClearPrinting();
void CloseWebInspector();
+ void CompositeAsyncThen(v8::Local<v8::Function> callback);
void CopyImageAtAndCapturePixelsAsyncThen(int x,
int y,
v8::Local<v8::Function> callback);
@@ -166,8 +167,6 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
void GetBluetoothManualChooserEvents(v8::Local<v8::Function> callback);
void GetManifestThen(v8::Local<v8::Function> callback);
void InsertStyleSheet(const std::string& source_code);
- void LayoutAndPaintAsync();
- void LayoutAndPaintAsyncThen(v8::Local<v8::Function> callback);
void LogToStderr(const std::string& output);
void NotImplemented(const gin::Arguments& args);
void NotifyDone();
@@ -352,6 +351,10 @@ gin::ObjectTemplateBuilder TestRunnerBindings::GetObjectTemplateBuilder(
.SetMethod("clearBackForwardList", &TestRunnerBindings::NotImplemented)
.SetMethod("clearPrinting", &TestRunnerBindings::ClearPrinting)
.SetMethod("closeWebInspector", &TestRunnerBindings::CloseWebInspector)
+ .SetMethod("compositeAsyncThen",
+ &TestRunnerBindings::CompositeAsyncThen)
+ .SetMethod("layoutAndPaintAsyncThen",
+ &TestRunnerBindings::CompositeAsyncThen)
.SetMethod("copyImageAtAndCapturePixelsAsyncThen",
&TestRunnerBindings::CopyImageAtAndCapturePixelsAsyncThen)
.SetMethod("didAcquirePointerLock",
@@ -442,10 +445,6 @@ gin::ObjectTemplateBuilder TestRunnerBindings::GetObjectTemplateBuilder(
.SetMethod("isChooserShown", &TestRunnerBindings::IsChooserShown)
.SetMethod("isCommandEnabled", &TestRunnerBindings::IsCommandEnabled)
.SetMethod("keepWebHistory", &TestRunnerBindings::NotImplemented)
- .SetMethod("layoutAndPaintAsync",
- &TestRunnerBindings::LayoutAndPaintAsync)
- .SetMethod("layoutAndPaintAsyncThen",
- &TestRunnerBindings::LayoutAndPaintAsyncThen)
.SetMethod("logToStderr", &TestRunnerBindings::LogToStderr)
.SetMethod("notifyDone", &TestRunnerBindings::NotifyDone)
.SetMethod("overridePreference", &TestRunnerBindings::OverridePreference)
@@ -1375,15 +1374,9 @@ void TestRunnerBindings::RemoveWebPageOverlay() {
view_runner_->RemoveWebPageOverlay();
}
-void TestRunnerBindings::LayoutAndPaintAsync() {
- if (view_runner_)
- view_runner_->LayoutAndPaintAsync();
-}
-
-void TestRunnerBindings::LayoutAndPaintAsyncThen(
- v8::Local<v8::Function> callback) {
+void TestRunnerBindings::CompositeAsyncThen(v8::Local<v8::Function> callback) {
if (view_runner_)
- view_runner_->LayoutAndPaintAsyncThen(callback);
+ view_runner_->CompositeAsyncThen(callback);
}
void TestRunnerBindings::GetManifestThen(v8::Local<v8::Function> callback) {
« no previous file with comments | « components/test_runner/pixel_dump.cc ('k') | components/test_runner/test_runner.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698