Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: components/test_runner/pixel_dump.cc

Issue 2034393003: testRunner.layoutAndPaintAsyncThen ==> testRunner.compositeAsyncThen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/composite_async_then.cc ('k') | components/test_runner/test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/pixel_dump.cc
diff --git a/components/test_runner/pixel_dump.cc b/components/test_runner/pixel_dump.cc
index fc859d782c521dfe0b3f6e5ad5301692ce8874ad..18dd43ff5d65ad6c156800775f079f291db3158d 100644
--- a/components/test_runner/pixel_dump.cc
+++ b/components/test_runner/pixel_dump.cc
@@ -54,6 +54,7 @@ class CaptureCallback : public blink::WebCompositeAndReadbackAsyncCallback {
}
// WebCompositeAndReadbackAsyncCallback implementation.
+ bool needsBitmap() const override;
void didCompositeAndReadback(const SkBitmap& bitmap) override;
private:
@@ -117,6 +118,10 @@ CaptureCallback::CaptureCallback(
CaptureCallback::~CaptureCallback() {}
+bool CaptureCallback::needsBitmap() const {
+ return true;
+}
+
void CaptureCallback::didCompositeAndReadback(const SkBitmap& bitmap) {
TRACE_EVENT2("shell", "CaptureCallback::didCompositeAndReadback", "x",
bitmap.info().width(), "y", bitmap.info().height());
« no previous file with comments | « components/test_runner/composite_async_then.cc ('k') | components/test_runner/test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698