Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2034383003: Removed exposed_services from mojom definitions. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove exposed_services from mojom definitions. * Also reorder the parameters to Application.AcceptConnection(): move |resolved_url| before |services|. * Make |services| non-nullable in the various ConnectToApplication()s. * Note: The version of monet is a magic local build, basically from monet acf6f027b6aebe79483f709ca5fd013d1dc77b0d with the changes in this CL to mojo/public copied in to monet's third_party/mojo/src/mojo/public (which is DEPSed into monet), and non-code changes committed locally to monet to get a different git hash (namely acf6f027b6aebe79483f709ca5fd013d1dc77b0d) in monet. R=jamesr@chromium.org BUG=#762 Committed: https://chromium.googlesource.com/external/mojo/+/568f845994392325f5a115a9d00b00207eeab62f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -206 lines) Patch
M apps/benchmark/benchmark_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M examples/content_handler_demo/content_handler_demo.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M examples/forwarding_content_handler/forwarding_content_handler.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/moterm_example_app/moterm_example_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/application.mojom.dart View 9 chunks +17 lines, -31 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/application_connector.mojom.dart View 8 chunks +10 lines, -24 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/shell.mojom.dart View 8 chunks +10 lines, -24 lines 0 comments Download
M mojo/dart/packages/mojo/lib/src/application.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/go/tests/application_impl_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gpu/gl_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/application_impl_base.h View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/connect.h View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/public/cpp/application/connection_context.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl_base.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M mojo/public/cpp/application/lib/application_test_base.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/go/application/application_impl.go View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/go/application/connection.go View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/interfaces/application/application.mojom View 2 chunks +2 lines, -28 lines 0 comments Download
M mojo/public/interfaces/application/application_connector.mojom View 1 chunk +1 line, -22 lines 0 comments Download
M mojo/public/interfaces/application/shell.mojom View 1 chunk +1 line, -7 lines 0 comments Download
M mojo/public/java/application/src/org/chromium/mojo/application/ApplicationImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/java/application/src/org/chromium/mojo/application/ShellHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/python/mojo_application/application_impl.py View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/tools/NETWORK_SERVICE_VERSION View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/js/application.js View 1 chunk +2 lines, -1 line 0 comments Download
M services/js/echo_apptest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/python/mojo_url_redirector/mojo_url_redirector_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/application_manager/shell_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M shell/application_manager/shell_impl.cc View 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
viettrungluu
4 years, 6 months ago (2016-06-06 21:08:41 UTC) #1
jamesr
lgtm
4 years, 6 months ago (2016-06-06 21:20:42 UTC) #3
viettrungluu
4 years, 6 months ago (2016-06-06 21:25:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
568f845994392325f5a115a9d00b00207eeab62f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698