Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: mojo/public/interfaces/application/application.mojom

Issue 2034383003: Removed exposed_services from mojom definitions. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/interfaces/application/application.mojom
diff --git a/mojo/public/interfaces/application/application.mojom b/mojo/public/interfaces/application/application.mojom
index 0ed5154e148e057b3e8478f034d50368ccf61081..11e139931ff5a161f67549c1dfc72dd8c65940e3 100644
--- a/mojo/public/interfaces/application/application.mojom
+++ b/mojo/public/interfaces/application/application.mojom
@@ -11,9 +11,6 @@ import "mojo/public/interfaces/application/shell.mojom";
// This is the primary interface implemented by every Mojo application. It
// allows the application to receive its startup arguments from the shell, and
// to be notified of events that occur during its execution.
-//
-// TODO(aa): It would be good to reorder the parameters once we have interface
-// versioning.
interface Application {
// Initializes the application with the specified arguments. This method is
// guaranteed to be called before any other method is called, and will only be
@@ -29,35 +26,12 @@ interface Application {
// Called when another application (identified by |requestor_url|) attempts to
// open a connection to this application.
//
- // If the other application wants to request services from this application,
- // it will have passed a valid interface request through the |services|
- // parameter (i.e. one containing a valid message pipe endpoint). This
- // application may then bind an implementation of |ServiceProvider| to that
- // request in order to make services available to the other application.
- //
- // If the other application wants to offer services to this application, it
- // will have passed a bound interface through the |exposed_services|
- // parameter. This application may then request services through that
- // interface.
- //
- // It is possible that both parameters will be valid/bound if the other
- // application wants to both request services from and offer services to this
- // application.
- //
- // This application is free to ignore the |services| or |exposed_services|
- // parameters if it does not wish to offer or request services.
- //
// resolved_url is the URL that was requested to create this connection, after
// all mappings, resolutions, and redirects. This will include any querystring
// that was part of the request.
- //
- // WARNING: |exposed_services| is deprecated and non-functional, and will be
- // removed. Note that this also means that |services| will become required.
- // https://github.com/domokit/mojo/issues/762
AcceptConnection(string requestor_url,
- ServiceProvider&? services,
- ServiceProvider? exposed_services,
- string resolved_url);
+ string resolved_url,
+ ServiceProvider& services);
// Called to request the application shut itself down gracefully.
RequestQuit();
« no previous file with comments | « mojo/public/go/application/connection.go ('k') | mojo/public/interfaces/application/application_connector.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698