Issue 2034293002: Just use the image skia from resouce bundle for default app icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2034293002: Just use the image skia from resouce bundle for default app icon. (Closed)

Created:
4 years, 6 months ago by oshima

Modified:
4 years, 6 months ago

Reviewers:
benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Just use the image skia from resouce bundle for default app icon. Another issue similar to 605884. BUG=614992 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2012273002 Cr-Commit-Position: refs/heads/master@{#397040} (cherry picked from commit b801ad2f00aff615076a2a1c22d76b68e61ae687) Committed: https://chromium.googlesource.com/chromium/src/+/f94447b764c82dbf7aeb27c0a087ffd6c9b1ae7d

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -14 lines)			Patch
	M	chrome/browser/extensions/extension_uninstall_dialog.cc	View		2 chunks	+4 lines, -14 lines	0 comments	Download

Total messages: 2 (1 generated)

oshima

4 years, 6 months ago (2016-06-03 22:38:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f94447b764c82dbf7aeb27c0a087ffd6c9b1ae7d.