Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2012273002: Just use the image skia from resouce bundle for default app icon. (Closed)

Created:
4 years, 6 months ago by oshima
Modified:
4 years, 6 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Just use the image skia from resouce bundle for default app icon. Another issue similar to 605884. BUG=614992 R=benwells@chromium.org Committed: https://crrev.com/b801ad2f00aff615076a2a1c22d76b68e61ae687 Cr-Commit-Position: refs/heads/master@{#397040}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 2 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012273002/20001
4 years, 6 months ago (2016-05-26 17:04:24 UTC) #3
oshima
4 years, 6 months ago (2016-05-26 17:08:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-26 18:02:14 UTC) #6
commit-bot: I haz the power
Dry run: None
4 years, 6 months ago (2016-05-26 18:02:29 UTC) #7
benwells
lgtm
4 years, 6 months ago (2016-05-30 07:21:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012273002/20001
4 years, 6 months ago (2016-06-01 01:48:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 03:27:57 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 03:29:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b801ad2f00aff615076a2a1c22d76b68e61ae687
Cr-Commit-Position: refs/heads/master@{#397040}

Powered by Google App Engine
This is Rietveld 408576698