Fix ResumableTCPSocket destruction.

Fix ResumableTCPSocket destruction.

ResumableTCPSocket sets a read_callback_ that points to
TCPSocketEventDispatcher::ReadCallback. This callback gets called
from ~TCPSocket, when ~ResumableTCPSocket already completed,
and it calls ResumableTCPSocket methods (which are already illegal to call).

The fix just calls Disconnect from ~ResumableTCPSocket which clears the
callback and all the state that relies on ResumableTCPSocket members.

This fixes a bug found with UBSan Vptr.

BUG=617199
Committed: https://crrev.com/feeee3ad3750286671cf2ca5e90400fa745a13d6
Cr-Commit-Position: refs/heads/master@{#397829}

[krasin, 2016-06-03 20:38:15]

krasin@google.com changed reviewers:
+ reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-06-03 20:44:34]

lgtm

[krasin, 2016-06-03 20:45:14]

The CQ bit was checked by krasin@google.com

[commit-bot: I haz the power, 2016-06-03 20:45:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034233002/1

[commit-bot: I haz the power, 2016-06-03 22:48:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-03 22:50:49]

Description was changed from

==========
Fix ResumableTCPSocket destruction.

ResumableTCPSocket sets a read_callback_ that points to
TCPSocketEventDispatcher::ReadCallback. This callback gets called
from ~TCPSocket, when ~ResumableTCPSocket already completed,
and it calls ResumableTCPSocket methods (which are already illegal to call).

The fix just calls Disconnect from ~ResumableTCPSocket which clears the
callback and all the state that relies on ResumableTCPSocket members.

This fixes a bug found with UBSan Vptr.

BUG=617199
==========

to

==========
Fix ResumableTCPSocket destruction.

ResumableTCPSocket sets a read_callback_ that points to
TCPSocketEventDispatcher::ReadCallback. This callback gets called
from ~TCPSocket, when ~ResumableTCPSocket already completed,
and it calls ResumableTCPSocket methods (which are already illegal to call).

The fix just calls Disconnect from ~ResumableTCPSocket which clears the
callback and all the state that relies on ResumableTCPSocket members.

This fixes a bug found with UBSan Vptr.

BUG=617199

Committed: https://crrev.com/feeee3ad3750286671cf2ca5e90400fa745a13d6
Cr-Commit-Position: refs/heads/master@{#397829}
==========

[commit-bot: I haz the power, 2016-06-03 22:50:50]

Patchset 1 (id:??) landed as
https://crrev.com/feeee3ad3750286671cf2ca5e90400fa745a13d6
Cr-Commit-Position: refs/heads/master@{#397829}