Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: extensions/browser/api/socket/tcp_socket.cc

Issue 2034233002: Fix ResumableTCPSocket destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/socket/tcp_socket.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/socket/tcp_socket.cc
diff --git a/extensions/browser/api/socket/tcp_socket.cc b/extensions/browser/api/socket/tcp_socket.cc
index f3ba5ee48d26621eb9822aa0356635f5cf368a52..4fb5913fc1ec5f13425648d4f2d626f44f548d3c 100644
--- a/extensions/browser/api/socket/tcp_socket.cc
+++ b/extensions/browser/api/socket/tcp_socket.cc
@@ -358,6 +358,14 @@ ResumableTCPSocket::ResumableTCPSocket(
buffer_size_(0),
paused_(false) {}
+ResumableTCPSocket::~ResumableTCPSocket() {
+ // Despite ~TCPSocket doing basically the same, we need to disconnect
+ // before ResumableTCPSocket is destroyed, because we have some extra
+ // state that relies on the socket being ResumableTCPSocket, like
+ // read_callback_.
+ Disconnect();
+}
+
bool ResumableTCPSocket::IsPersistent() const { return persistent(); }
ResumableTCPServerSocket::ResumableTCPServerSocket(
« no previous file with comments | « extensions/browser/api/socket/tcp_socket.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698