components/page_load_metrics/browser/page_load_metrics_observer.h - Issue 2034223002: Add immediate variants of doc.write page load metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.h

Issue 2034223002: Add immediate variants of doc.write page load metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bryan's latest feedback incorporated. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/page_load_metrics_observer.h

diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.h b/components/page_load_metrics/browser/page_load_metrics_observer.h

index 796a3678ce8a12b490c55192a38262a9f00aa46d..0208684930f68ce121fefc1c8d94fb347ddfa113 100644

--- a/components/page_load_metrics/browser/page_load_metrics_observer.h

+++ b/components/page_load_metrics/browser/page_load_metrics_observer.h

@@ -179,6 +179,8 @@ class PageLoadMetricsObserver {

const PageLoadExtraInfo& extra_info) {}

virtual void OnParseStop(const PageLoadTiming& timing,

const PageLoadExtraInfo& extra_info) {}

+ virtual void OnLoadingBehaviorObserved(

Charlie Harrison 2016/06/17 21:36:19 Can you document this method? The others are a bit

+ const page_load_metrics::PageLoadExtraInfo& extra_info) {}

};

} // namespace page_load_metrics