components/page_load_metrics/browser/page_load_metrics_observer.h - Issue 2034223002: Add immediate variants of doc.write page load metrics

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/page_load_metrics/browser/page_load_metrics_observer.h

Issue 2034223002: Add immediate variants of doc.write page load metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bryan's latest feedback incorporated. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_OBSERVER_H_	5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_OBSERVER_H_

6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_OBSERVER_H_	6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_OBSERVER_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "components/page_load_metrics/common/page_load_timing.h"	9 #include "components/page_load_metrics/common/page_load_timing.h"

10 #include "content/public/browser/navigation_handle.h"	10 #include "content/public/browser/navigation_handle.h"

(...skipping 161 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
172 virtual void OnFirstTextPaint(const PageLoadTiming& timing,	172 virtual void OnFirstTextPaint(const PageLoadTiming& timing,

173 const PageLoadExtraInfo& extra_info) {}	173 const PageLoadExtraInfo& extra_info) {}

174 virtual void OnFirstImagePaint(const PageLoadTiming& timing,	174 virtual void OnFirstImagePaint(const PageLoadTiming& timing,

175 const PageLoadExtraInfo& extra_info) {}	175 const PageLoadExtraInfo& extra_info) {}

176 virtual void OnFirstContentfulPaint(const PageLoadTiming& timing,	176 virtual void OnFirstContentfulPaint(const PageLoadTiming& timing,

177 const PageLoadExtraInfo& extra_info) {}	177 const PageLoadExtraInfo& extra_info) {}

178 virtual void OnParseStart(const PageLoadTiming& timing,	178 virtual void OnParseStart(const PageLoadTiming& timing,

179 const PageLoadExtraInfo& extra_info) {}	179 const PageLoadExtraInfo& extra_info) {}

180 virtual void OnParseStop(const PageLoadTiming& timing,	180 virtual void OnParseStop(const PageLoadTiming& timing,

181 const PageLoadExtraInfo& extra_info) {}	181 const PageLoadExtraInfo& extra_info) {}

	182 virtual void OnLoadingBehaviorObserved(
	Charlie Harrison 2016/06/17 21:36:19 Can you document this method? The others are a bit Can you document this method? The others are a bit self explanatory.
	183 const page_load_metrics::PageLoadExtraInfo& extra_info) {}

182 };	184 };

183	185

184 } // namespace page_load_metrics	186 } // namespace page_load_metrics

185	187

186 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_OBSERVER_H_	188 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_OBSERVER_H_

OLD	NEW