components/dom_distiller/content/renderer/distillability_agent.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/renderer/distillability_agent.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/contextual_search/renderer/overlay_js_render_frame_observer.cc ('k') | components/dom_distiller/content/renderer/distillability_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/renderer/distillability_agent.h

diff --git a/components/dom_distiller/content/renderer/distillability_agent.h b/components/dom_distiller/content/renderer/distillability_agent.h

index 940f7c166912da0392525becf48910d52a3c6264..68772487006d175af0144aa5ab6f27d39b30861c 100644

--- a/components/dom_distiller/content/renderer/distillability_agent.h

+++ b/components/dom_distiller/content/renderer/distillability_agent.h

@@ -17,6 +17,7 @@ class DistillabilityAgent : public content::RenderFrameObserver {

// content::RenderFrameObserver:

void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;

+ void OnDestruct() override;

};

} // namespace dom_distiller