Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/nacl/renderer/nacl_helper.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/renderer/nacl_helper.h ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer.h » ('j') | content/public/renderer/render_frame_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/nacl_helper.cc
diff --git a/components/nacl/renderer/nacl_helper.cc b/components/nacl/renderer/nacl_helper.cc
index 516096a3dbbec41990e1dc5404412459f9211748..8ee771f0c5c97df3c82584cd63e8e3389de09308 100644
--- a/components/nacl/renderer/nacl_helper.cc
+++ b/components/nacl/renderer/nacl_helper.cc
@@ -19,4 +19,8 @@ void NaClHelper::DidCreatePepperPlugin(content::RendererPpapiHost* host) {
host->SetToExternalPluginHost();
}
+void NaClHelper::OnDestruct() {
+ delete this;
+}
+
} // namespace nacl
« no previous file with comments | « components/nacl/renderer/nacl_helper.h ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer.h » ('j') | content/public/renderer/render_frame_observer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698