Chromium Code Reviews| Index: content/public/renderer/render_frame_observer.h |
| diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h |
| index bf7c6eee7a7c83761e2b36af34ad002b88bee9e9..3a526de7206a87ca561bca0383112202d0ac11de 100644 |
| --- a/content/public/renderer/render_frame_observer.h |
| +++ b/content/public/renderer/render_frame_observer.h |
| @@ -37,9 +37,10 @@ class RenderFrameImpl; |
| class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener, |
| public IPC::Sender { |
| public: |
| - // By default, observers will be deleted when the RenderFrame goes away. If |
| - // they want to outlive it, they can override this function. |
| - virtual void OnDestruct(); |
| + // Subclass can use this to delete itself. If it does not, the subclass must |
|
miu
2016/06/07 17:56:30
nit: s/Subclass/A subclass/
xjz
2016/06/07 18:08:54
Done.
|
| + // always null-check each call to render_frame() becase the RenderFrame can |
| + // go away at any time. |
| + virtual void OnDestruct() = 0; |
| // Called when a Pepper plugin is created. |
| virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {} |