Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/contextual_search/renderer/overlay_js_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/contextual_search/renderer/overlay_js_render_frame_observer.h ('k') | components/dom_distiller/content/renderer/distillability_agent.h » ('j') | content/public/renderer/render_frame_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/contextual_search/renderer/overlay_js_render_frame_observer.cc
diff --git a/components/contextual_search/renderer/overlay_js_render_frame_observer.cc b/components/contextual_search/renderer/overlay_js_render_frame_observer.cc
index ef123cd9f783139f5ab2d969fe15bf5c4ead3400..0966350e8f45797c8d6e4c30c40ea2af496920e3 100644
--- a/components/contextual_search/renderer/overlay_js_render_frame_observer.cc
+++ b/components/contextual_search/renderer/overlay_js_render_frame_observer.cc
@@ -58,4 +58,8 @@ void OverlayJsRenderFrameObserver::DidFinishLoad() {
->RemoveService<mojom::OverlayPageNotifierService>();
}
+void OverlayJsRenderFrameObserver::OnDestruct() {
+ delete this;
+}
+
} // namespace contextual_search
« no previous file with comments | « components/contextual_search/renderer/overlay_js_render_frame_observer.h ('k') | components/dom_distiller/content/renderer/distillability_agent.h » ('j') | content/public/renderer/render_frame_observer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698