Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 2034003002: Revert of ImageCapture: move mojom from WebKit/public to media/ (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ImageCapture: move mojom from WebKit/public to media/ (patchset #4 id:60002 of https://codereview.chromium.org/2027023002/ ) Reason for revert: Appears to cause: imagecapture/getphotocapabilities.html imagecapture/takephoto.html to timeout. (https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/42976/layout-test-results/results.html) Original issue's description: > ImageCapture: move mojom from WebKit/public to media/ > > This CL moves image_capture.mojom from > {third_party/WebKit/public/platform/modules => media/mojo/interfaces} > so the generated data types (e.g. PhotoCapabilities{Ptr}) > can be used from both Blink and media/capture locations. > > Also capture.gypi is trivially relocated to capture/ folder. > > Note that gyp files are -yay!- close to being finally > removed. > > BUG=518807 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel > > Committed: https://crrev.com/64aec45d94682ae3b38c0f1c18ff74cd937ff9b5 > Cr-Commit-Position: refs/heads/master@{#397644} TBR=dcheng@chromium.org,avi@chromium.org,haraken@chromium.org,rockot@chromium.org,xhwang@chromium.org,dalecurtis@chromium.org,esprehn@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518807 Committed: https://crrev.com/f42a01f2416601c8374af0e45d1aeb4ad38ee501 Cr-Commit-Position: refs/heads/master@{#397663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -197 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/image_capture_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/media/capture/image_capture_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A media/capture.gypi View 1 chunk +106 lines, -0 lines 0 comments Download
D media/capture/capture.gypi View 1 chunk +0 lines, -106 lines 0 comments Download
M media/media.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D media/mojo/interfaces/image_capture.mojom View 1 chunk +0 lines, -35 lines 0 comments Download
M media/mojo/interfaces/mojo_bindings.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/imagecapture/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/imagecapture/OWNERS View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/imagecapture/image_capture.mojom View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
Created Revert of ImageCapture: move mojom from WebKit/public to media/
4 years, 6 months ago (2016-06-03 08:21:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034003002/1
4 years, 6 months ago (2016-06-03 08:21:45 UTC) #3
haraken
LGTM
4 years, 6 months ago (2016-06-03 08:22:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 08:22:40 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 08:24:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f42a01f2416601c8374af0e45d1aeb4ad38ee501
Cr-Commit-Position: refs/heads/master@{#397663}

Powered by Google App Engine
This is Rietveld 408576698