Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2027023002: ImageCapture: move mojom from WebKit/public to media/ (Closed)

Created:
4 years, 6 months ago by mcasas
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageCapture: move mojom from WebKit/public to media/ This CL moves image_capture.mojom from {third_party/WebKit/public/platform/modules => media/mojo/interfaces} so the generated data types (e.g. PhotoCapabilities{Ptr}) can be used from both Blink and media/capture locations. Also capture.gypi is trivially relocated to capture/ folder. Note that gyp files are -yay!- close to being finally removed. BUG=518807 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel Committed: https://crrev.com/64aec45d94682ae3b38c0f1c18ff74cd937ff9b5 Cr-Commit-Position: refs/heads/master@{#397644}

Patch Set 1 : Rebase #

Total comments: 2

Patch Set 2 : rockot@s comment, image_capture.mojom to media/mojo/interfaces/ #

Total comments: 4

Patch Set 3 : change include path in mock-imagecapture.js #

Patch Set 4 : Restricted DEPS, added .mojom comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -165 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/capture/image_capture_impl.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/media/capture/image_capture_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
D media/capture.gypi View 1 chunk +0 lines, -106 lines 0 comments Download
A + media/capture/capture.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
M media/media.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download
A media/mojo/interfaces/image_capture.mojom View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
M media/mojo/interfaces/mojo_bindings.gyp View 1 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/imagecapture/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/platform/modules/imagecapture/OWNERS View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/public/platform/modules/imagecapture/image_capture.mojom View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 50 (21 generated)
mcasas
rockot@ PTAL at the concept (I'll collect the LGTMs for namespace updates separately).
4 years, 6 months ago (2016-06-01 17:37:35 UTC) #8
Ken Rockot(use gerrit already)
https://codereview.chromium.org/2027023002/diff/60001/media/capture/imagecapture/image_capture.mojom File media/capture/imagecapture/image_capture.mojom (right): https://codereview.chromium.org/2027023002/diff/60001/media/capture/imagecapture/image_capture.mojom#newcode2 media/capture/imagecapture/image_capture.mojom:2: // Use of this source code is governed by ...
4 years, 6 months ago (2016-06-01 19:13:08 UTC) #10
mcasas
rockot@ PTAL (I still kept image_capture.mojom separate from the other mojoms that are selectively compiled) ...
4 years, 6 months ago (2016-06-01 19:57:45 UTC) #11
Ken Rockot(use gerrit already)
lgtm On 2016/06/01 at 19:57:45, mcasas wrote: > rockot@ PTAL > > (I still kept ...
4 years, 6 months ago (2016-06-01 20:02:36 UTC) #12
mcasas
avi@ RS plz content/ changes xhwang@ RS plz media/ changes dcheng@ RS added file to ...
4 years, 6 months ago (2016-06-01 20:55:34 UTC) #15
dcheng
rs lgtm for mojom move
4 years, 6 months ago (2016-06-01 20:59:31 UTC) #17
Avi (use Gerrit)
lgtm content stamp
4 years, 6 months ago (2016-06-01 21:08:20 UTC) #18
xhwang
+haraken the Blink owner. hmm, I don't think blink should depend on media, which is ...
4 years, 6 months ago (2016-06-01 22:15:03 UTC) #19
Ken Rockot(use gerrit already)
On 2016/06/01 at 22:15:03, xhwang wrote: > +haraken the Blink owner. > > hmm, I ...
4 years, 6 months ago (2016-06-01 22:32:41 UTC) #20
haraken
WebKit LGTM
4 years, 6 months ago (2016-06-01 23:21:29 UTC) #21
xhwang
+dalecurtis, FYI I agree that having to have a single mojom file living in components/ ...
4 years, 6 months ago (2016-06-01 23:22:04 UTC) #23
haraken
Sorry, I LGed without noticing xhwang's comment. xhwang's makes sense. Looking.
4 years, 6 months ago (2016-06-01 23:25:03 UTC) #24
mcasas
Note that WebKit/modules already pulls mojom-generated data types from other top-level folders, i.e.: $ grep ...
4 years, 6 months ago (2016-06-01 23:31:02 UTC) #25
haraken
+Elliott: The question is if it's ok to add a DEPS from modules/imagecapture/ to src/media/mojo/interfaces/. ...
4 years, 6 months ago (2016-06-01 23:35:45 UTC) #27
xhwang
On 2016/06/01 23:31:02, mcasas wrote: > Note that WebKit/modules already pulls mojom-generated > data types ...
4 years, 6 months ago (2016-06-01 23:37:57 UTC) #28
xhwang
On 2016/06/01 23:31:02, mcasas wrote: > Note that WebKit/modules already pulls mojom-generated > data types ...
4 years, 6 months ago (2016-06-01 23:38:01 UTC) #29
haraken
On 2016/06/01 23:31:02, mcasas wrote: > Note that WebKit/modules already pulls mojom-generated > data types ...
4 years, 6 months ago (2016-06-01 23:39:15 UTC) #30
mcasas
On 2016/06/01 23:35:45, haraken wrote: > +Elliott: The question is if it's ok to add ...
4 years, 6 months ago (2016-06-01 23:48:39 UTC) #31
mcasas
On 2016/06/01 23:38:01, xhwang wrote: > On 2016/06/01 23:31:02, mcasas wrote: > > Note that ...
4 years, 6 months ago (2016-06-01 23:49:27 UTC) #32
haraken
LGTM on my side, but I'd like to have Elliott confirm.
4 years, 6 months ago (2016-06-01 23:51:50 UTC) #33
mcasas
On 2016/06/01 23:51:50, haraken wrote: > LGTM on my side, but I'd like to have ...
4 years, 6 months ago (2016-06-02 23:56:49 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027023002/60002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027023002/60002
4 years, 6 months ago (2016-06-02 23:57:55 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/76114) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-03 00:31:06 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027023002/60002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027023002/60002
4 years, 6 months ago (2016-06-03 00:34:07 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/232682)
4 years, 6 months ago (2016-06-03 03:03:15 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027023002/60002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027023002/60002
4 years, 6 months ago (2016-06-03 04:03:12 UTC) #45
commit-bot: I haz the power
Committed patchset #4 (id:60002)
4 years, 6 months ago (2016-06-03 05:57:02 UTC) #47
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/64aec45d94682ae3b38c0f1c18ff74cd937ff9b5 Cr-Commit-Position: refs/heads/master@{#397644}
4 years, 6 months ago (2016-06-03 05:58:55 UTC) #49
fs
4 years, 6 months ago (2016-06-03 08:21:30 UTC) #50
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60002) has been created in
https://codereview.chromium.org/2034003002/ by fs@opera.com.

The reason for reverting is: Appears to cause:

imagecapture/getphotocapabilities.html
imagecapture/takephoto.html

to timeout.

(https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/4297...).

Powered by Google App Engine
This is Rietveld 408576698