Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2033943005:
[stubs] Enable TurboFan LoadIC dispatcher stub. (Closed)
|
Created:
4 years, 6 months ago by Igor Sheludko Modified:
4 years, 6 months ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com, Michael Hablich Base URL:
https://chromium.googlesource.com/v8/v8.git@load-ic-stub-tf Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[stubs] Enable TurboFan LoadIC dispatcher stub.
Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2
Committed: https://crrev.com/25af5d3d325f3a9aced80fee02df29155b4c695e
Cr-Original-Commit-Position: refs/heads/master@{#36760}
Cr-Commit-Position: refs/heads/master@{#36800}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 20 (9 generated)
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
ishell@chromium.org changed reviewers: + verwaest@chromium.org
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033943005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033943005/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033943005/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [stubs] Enable TurboFan LoadIC dispatcher stub. ========== to ========== [stubs] Enable TurboFan LoadIC dispatcher stub. Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 Cr-Commit-Position: refs/heads/master@{#36760} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 Cr-Commit-Position: refs/heads/master@{#36760}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2042873002/ by adamk@chromium.org. The reason for reverting is: Fails cctest consistently on Linux nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2....
Message was sent while issue was closed.
Description was changed from ========== [stubs] Enable TurboFan LoadIC dispatcher stub. Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 Cr-Commit-Position: refs/heads/master@{#36760} ========== to ========== [stubs] Enable TurboFan LoadIC dispatcher stub. Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 Cr-Commit-Position: refs/heads/master@{#36760} ==========
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033943005/1
Message was sent while issue was closed.
Description was changed from ========== [stubs] Enable TurboFan LoadIC dispatcher stub. Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 Cr-Commit-Position: refs/heads/master@{#36760} ========== to ========== [stubs] Enable TurboFan LoadIC dispatcher stub. Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 Cr-Commit-Position: refs/heads/master@{#36760} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [stubs] Enable TurboFan LoadIC dispatcher stub. Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 Cr-Commit-Position: refs/heads/master@{#36760} ========== to ========== [stubs] Enable TurboFan LoadIC dispatcher stub. Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 Committed: https://crrev.com/25af5d3d325f3a9aced80fee02df29155b4c695e Cr-Original-Commit-Position: refs/heads/master@{#36760} Cr-Commit-Position: refs/heads/master@{#36800} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/25af5d3d325f3a9aced80fee02df29155b4c695e Cr-Commit-Position: refs/heads/master@{#36800} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
