[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to enable them instead of …

[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to enable them instead of respective platform stubs.

The stubs do not increase respective counters as they are in the snapshot and --native-code-counters is off during snapshot creation anyway.

Committed: https://crrev.com/f1ffe311639594f4855f18e2fa2edceef1cbf013
Cr-Commit-Position: refs/heads/master@{#36754}

[Igor Sheludko, 2016-06-02 17:31:04]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 17:31:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031753003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031753003/1

[commit-bot: I haz the power, 2016-06-02 17:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 17:34:00]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/6645)

[Igor Sheludko, 2016-06-03 06:50:28]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 06:50:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031753003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031753003/20001

[commit-bot: I haz the power, 2016-06-03 06:54:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 06:54:01]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Igor Sheludko, 2016-06-03 12:26:55]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 12:27:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031753003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031753003/40001

[Igor Sheludko, 2016-06-03 12:29:00]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 12:29:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031753003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031753003/60001

[Igor Sheludko, 2016-06-03 12:56:26]

Description was changed from

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective handwritten stubs.
==========

to

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective handwritten stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot generating anyway.
==========

[Igor Sheludko, 2016-06-03 12:56:58]

Description was changed from

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective handwritten stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot generating anyway.
==========

to

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective handwritten stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot creation anyway.
==========

[Igor Sheludko, 2016-06-03 12:58:57]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 12:59:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031753003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031753003/80001

[Igor Sheludko, 2016-06-03 13:00:26]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2016-06-03 13:00:27]

PTAL. According to try run results it seems to work (see patch set 3 where the
new stubs were enabled).

https://codereview.chromium.org/2031753003/diff/80001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (left):

https://codereview.chromium.org/2031753003/diff/80001/src/code-stub-assembler...
src/code-stub-assembler.cc:1480: // TODO(ishell): Remove this trampoline block
once crbug/615621 is fixed.
The bug is fixed.

[Igor Sheludko, 2016-06-03 13:04:50]

Description was changed from

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective handwritten stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot creation anyway.
==========

to

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective hand written stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot creation anyway.
==========

[Igor Sheludko, 2016-06-03 13:05:07]

Description was changed from

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective hand written stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot creation anyway.
==========

to

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot creation anyway.
==========

[Michael Starzinger, 2016-06-03 13:06:14]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-06-03 13:06:14]

LGTM on "compiler", didn't look at the rest.

[commit-bot: I haz the power, 2016-06-03 13:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 13:25:27]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-06-06 12:47:33]

lgtm

https://codereview.chromium.org/2031753003/diff/80001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2031753003/diff/80001/src/code-stub-assembler...
src/code-stub-assembler.cc:573: Node* CodeStubAssembler::LoadWeakCellValue(Node*
map) {
map is a weird variable name :)

[Igor Sheludko, 2016-06-06 13:55:07]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-06-06 13:55:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2031753003/#ps100001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-06-06 13:55:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031753003/100001

[commit-bot: I haz the power, 2016-06-06 14:26:33]

Description was changed from

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot creation anyway.
==========

to

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot creation anyway.
==========

[commit-bot: I haz the power, 2016-06-06 14:26:34]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-06 14:28:28]

Description was changed from

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot creation anyway.
==========

to

==========
[stubs] Introducing LoadICTFStub and LoadICTrampolineTFStub and a switch to
enable them instead of respective platform stubs.

The stubs do not increase respective counters as they are in the snapshot and
--native-code-counters is off during snapshot creation anyway.

Committed: https://crrev.com/f1ffe311639594f4855f18e2fa2edceef1cbf013
Cr-Commit-Position: refs/heads/master@{#36754}
==========

[commit-bot: I haz the power, 2016-06-06 14:28:30]

Patchset 6 (id:??) landed as
https://crrev.com/f1ffe311639594f4855f18e2fa2edceef1cbf013
Cr-Commit-Position: refs/heads/master@{#36754}

[adamk, 2016-06-06 19:08:28]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-06-06 19:08:29]

https://codereview.chromium.org/2031753003/diff/100001/test/cctest/test-code-...
File test/cctest/test-code-stub-assembler.cc (right):

https://codereview.chromium.org/2031753003/diff/100001/test/cctest/test-code-...
test/cctest/test-code-stub-assembler.cc:1242: TEST(TryProbeStubCache) {
This test seems to flake consistently on Linux nosnap debug:

https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2...

PTAL.

[Yang, 2016-06-07 06:37:11]

On 2016/06/06 19:08:29, adamk wrote:
>
https://codereview.chromium.org/2031753003/diff/100001/test/cctest/test-code-...
> File test/cctest/test-code-stub-assembler.cc (right):
> 
>
https://codereview.chromium.org/2031753003/diff/100001/test/cctest/test-code-...
> test/cctest/test-code-stub-assembler.cc:1242: TEST(TryProbeStubCache) {
> This test seems to flake consistently on Linux nosnap debug:
> 
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2...
> 
> PTAL.

Yup. Igor, please fix the timeout issue
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2...

[Igor Sheludko, 2016-06-07 14:29:16]

On 2016/06/07 06:37:11, Yang wrote:
> On 2016/06/06 19:08:29, adamk wrote:
> >
>
https://codereview.chromium.org/2031753003/diff/100001/test/cctest/test-code-...
> > File test/cctest/test-code-stub-assembler.cc (right):
> > 
> >
>
https://codereview.chromium.org/2031753003/diff/100001/test/cctest/test-code-...
> > test/cctest/test-code-stub-assembler.cc:1242: TEST(TryProbeStubCache) {
> > This test seems to flake consistently on Linux nosnap debug:
> > 
> >
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2...
> > 
> > PTAL.
> 
> Yup. Igor, please fix the timeout issue
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2...

The fix is on the way: https://codereview.chromium.org/2040193002/